Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pct_above_x not encoded as a percentage. #10

Open
alkc opened this issue Aug 14, 2023 · 0 comments
Open

pct_above_x not encoded as a percentage. #10

alkc opened this issue Aug 14, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@alkc
Copy link

alkc commented Aug 14, 2023

The QC parameter pct_above_x is encoded as an actual percentage, (that is to say a floating point number between 0 - 100). in the majority of assays/pipelines that use it, except for wgs and tumwgs where it is a fraction:

{
'sample-id' : 'some sample in CDM'
'assay' : 'tumwgs',
...
    'qc' {
        'pct_above_x': {
             '1': '0.98739',   
             '10': '0.97882',
             '100': '0.0023136',
             '15': '0.96606',
             '20': '0.9404',
             ...
         }
     }
}

It's a minor issue but fixing it would remove the need to employ special formatting rules for tumwgs samples when displaying pct_above_x in CDM and bring the data in line with the parameter name.

@alkc alkc added the bug Something isn't working label Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant