Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4347: Flag for submissions UI and CLI #4349

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fix #4347: Flag for submissions UI and CLI #4349

wants to merge 9 commits into from

Conversation

Harshit28j
Copy link

This PR resolves #4347

If submission is made through UI:
UI

If submission is made through CLI:
CLI

@Harshit28j
Copy link
Author

@RishabhJain2018, could you please review the PR?

gchhablani
gchhablani reviewed Apr 20, 2024
View reviewed changes
Copy link
Collaborator

@gchhablani gchhablani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed this PR. Please make the changes.
Also, you will have to update the variable when the submissions are pushed to evalai. Plesae make those changes are well.

apps/jobs/models.py Outdated Show resolved Hide resolved
RishabhJain2018
RishabhJain2018 reviewed Apr 20, 2024
View reviewed changes
Copy link
Member

@RishabhJain2018 RishabhJain2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the build as well : https://app.travis-ci.com/github/Cloud-CV/EvalAI/builds/270091034

@Harshit28j Harshit28j mentioned this pull request Apr 21, 2024
Open
@Harshit28j
Copy link
Author

The addition of 'from_cli' to models.py and database migration have caused build failure. This is because the existing tests were designed for the previous database schema.
To resolve this, Add updated test cases as per new db schema

image

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.30%. Comparing base (96968d6) to head (e687dc0).
Report is 1110 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4349      +/-   ##
==========================================
- Coverage   72.93%   69.30%   -3.63%     
==========================================
  Files          83       20      -63     
  Lines        5368     3574    -1794     
==========================================
- Hits         3915     2477    -1438     
+ Misses       1453     1097     -356

see 64 files with indirect coverage changes

see 64 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da7e068...e687dc0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchhablani gchhablani gchhablani left review comments

@RishabhJain2018 RishabhJain2018 RishabhJain2018 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a flag to submissions for CLI vs UI
4 participants
@Harshit28j @codecov-commenter @RishabhJain2018 @gchhablani