-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyerror on logging errors when found in making a call to api #313
Comments
Hi @burnerlee, I run in the same error as you. I'm using a fresh install of v1.3.12. |
@burnerlee nice catch, this error response is from jwt token API that we added recently. If you are interested you can pick this issue and send a PR to fix it. |
@Ram81 yeah sure, I'll make a PR for this |
@Ram81, should I do something like, checking if error key is present in the response, if it does, use the same value, if it doesn't then use the detail key for getting the error? |
@burnerlee yes |
Oh okay, it is only this jwt error log which causes this error, or there may be some other errors too? Which need to be handled 😅 |
For now its just the JWT API which has a different error response format. Rest of our APIs are already handled |
thank you so much ❤️ |
When an error is received while making a request to the backend, we catch it, and if it is present in the EVALAI_ERROR_CODES, we log it using the lines:
But response.json() does not have the key
error
in cases. For e.g., I made a request using an expired token and got an error. So when I logged the entire json.response(), it was something likeThis does not contains a key named error
The text was updated successfully, but these errors were encountered: