Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Features Improvements #40

Open
nesimtunc opened this issue Jun 7, 2020 · 3 comments
Open

Notification Features Improvements #40

nesimtunc opened this issue Jun 7, 2020 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@nesimtunc
Copy link
Member

We got 2 new issues @umurgdk

  1. When user changes notification permission from iOS Settings, and comes back to CoThings Notification Settings (where left via "Allow Notifications" button), that button will be there because onAppear method doesn't call when the screen re-appear.

  2. CoThingsBackend doesn't have the latest list of the rooms when connecting in the background.

Shall we merge this pull request and create these issues as bugs?

Originally posted by @nesimtunc in #36 (comment)

@nesimtunc nesimtunc added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jun 7, 2020
@ishansharma
Copy link
Contributor

Since this is tagged good first issue, I'd be happy to take a look. Do you want to merge it or should I look at PR and get the fix ready and then merge both?

@nesimtunc
Copy link
Member Author

This is not urgent, @umurgdk might be already working on it, but let's consider after you done with #9 issue.

Thank youuuuu @ishansharma

@umurgdk
Copy link
Collaborator

umurgdk commented Jun 13, 2020

@ishansharma @nesimtunc Unfortunately I will not be able to work on the project for a little while. So @ishansharma please welcome to make any improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants