Infinite stepping sound

[andreasdc]

Observed Behavior

Sometimes players that are standing still are sending stepping sound infinitely.

Expected Behavior

Stepping sound should be played only when moving.

Steps To Reproduce

Join the server with lags? Can't tell exactly in what situations.

Plugin List

No response

Server Version

[10:16:30 INFO]: This server is running NachoSpigot version git-NachoSpigot-"393f913" (MC: 1.8.8) (Implementing API version 1.8.8-R0.2-SNAPSHOT)
[10:16:30 INFO]: You are running the latest version

Other

Pretty old bug as I believe.

Agreements

• You were able to find this issue on the latest version of NachoSpigot.
• You have confirmed that there aren’t any issues open regarding this bug.
• You have confirmed that you are NOT using a fork of NachoSpigot in any way. YOUR changes are not OUR faults.

[sadcenter]

NachoSpigot/NachoSpigot-Server/src/main/java/net/minecraft/server/Entity.java

Line 815 in 98268b2

block.a(this.world, blockposition, this); // CraftBukkit moved from above

We could add check has player block changed but I don't think it would make sense since you can make a step sound on a block without changing position. Anyway, I decided to test will this check pass and won't break anything, surprisingly it doesn't break the steps sound - Should we make a config option for this?

[andreasdc]

NachoSpigot/NachoSpigot-Server/src/main/java/net/minecraft/server/Entity.java

Line 815 in 98268b2

block.a(this.world, blockposition, this); // CraftBukkit moved from above

We could add check has player position changed but I don't think it would make sense since you can make a step sound on a block without changing position. Anyway, I decided to test will this check pass and won't break anything, surprisingly it doesn't break the steps sound - Should we make a config option for this?

How do you want to make a step sound without moving?

[sadcenter]

I meant to check if the block the player is standing on has changed
if(positionChanged) {

[andreasdc]

I meant to check if the block the player is standing on has changed if(positionChanged) {

"since you can make a step sound on a block without changing position"?

NachoSpigot/NachoSpigot-Server/src/main/java/net/minecraft/server/Entity.java

Line 802 in 98268b2

if (this.N > (float) this.h && block.getMaterial() != Material.AIR) {

Isn't this line just broken?

[sadcenter]

https://streamable.com/ntpdov
"since you can make a step sound on a block without changing position"? I meant x, y, z as an integer. (Without fraction)
I haven't changed the block but still made a sound.

[andreasdc]

https://streamable.com/ntpdov "since you can make a step sound on a block without changing position"? I meant x, y, z as an integer. (Without fraction) I haven't changed the block but still made a sound.

Oh yea but you moved

[RobinRMC]

It's when two or more players are standing on the same block as far as I know.