Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign up with GitHub button off-center on mobile site #355

Open
1 task
rachelmad opened this issue Feb 28, 2015 · 1 comment
Open
1 task

Sign up with GitHub button off-center on mobile site #355

rachelmad opened this issue Feb 28, 2015 · 1 comment

Comments

@rachelmad
Copy link
Contributor

Description
The sign up with GitHub button is slightly off-center on the mobile site. It's very minor, but kind of weird looking since the text below it is centered. See the screenshot below for an example.

2015-02-28 23 34 33

Ask
Center the sign up button on mobile displays.

To Do

  • Adjust button placement to be centered in mobile views

Additional Info
Use Foundation 4 standards & classes for media queries, etc: http://foundation.zurb.com/docs/v/4.3.2/

@laramelniker
Copy link

Hi @courte , you may remember me from the open source talk you gave at the coding school downtown about 2 weeks ago. I got my dev environment for CodeMontage up tonight and took a stab at this issue. Here are some screenshots before/after and two screen sizes (desktop and iphone5). I believe I submitted a pull request, but I think it got assigned a different issue number (#391)? This is my first pull request - ever - so please let me know how to be better next time or if I should make any changes for this one!

before
after

🎱

I'm also confused by the reference to this issue from Mar 21st (#368) since the reference has errors, but it looks like it was merged? Does it mean this issue is already resolved and I just can't see it? I hope this isn't an inappropriate place for such a long message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants