Java app build extension #348
Conversation
This uses an event to run the mvnw build (or it can be customised via options), so it is only used when the app host is running the resource Fixes #339
Minimum allowed line rate is |
| State = new($"mvnw exited with {mvnw.ExitCode}", KnownResourceStates.FailedToStart) | ||
| }).ConfigureAwait(false); | ||
|
|
||
| throw new InvalidOperationException($"mvnw build failed with exit code {mvnw.ExitCode}"); |
There was a problem hiding this comment.
It's how I've seen other hooks implemented in the past.
There was a problem hiding this comment.
Where does this show up? Wouldn't it be better to show it in the dashboard? Also what happens when the build fails? Do I need to restart the entire apphost to rebuild or can I trigger it from the dashboard? (custom command)
Worth thinking through that I think.
There was a problem hiding this comment.
The notification service reporting shows up on the dashboard and I think the exception bubbles to the console of the resource that it was relative for.
A custom command would be a good idea to run a rebuild, I'll add that.
| private static IResourceBuilder<JavaAppExecutableResource> WithJavaDefaults( | ||
| this IResourceBuilder<JavaAppExecutableResource> builder, | ||
| JavaAppExecutableResourceOptions options) => | ||
| builder.WithOtlpExporter() |
There was a problem hiding this comment.
Does this work without making https work?
There was a problem hiding this comment.
Without HTTPS on the dashboard?
This uses an event to run the mvnw build (or it can be customised via options), so it is only used when the app host is running the resource
Closes #339
PR Checklist
Other information