Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Make Submodule of main Toolkit project? #66

Open
michael-hawker opened this issue Jan 14, 2021 · 1 comment
Open

[Feature] Make Submodule of main Toolkit project? #66

michael-hawker opened this issue Jan 14, 2021 · 1 comment

Comments

@michael-hawker
Copy link
Member

Describe the problem this feature would solve

We should probably add this repo as a submodule to our main toolkit repo to help with integration within the main Sample app.

Currently, we have to build the Toolkit (which is referenced by the graph controls), then build the Graph Controls, and then reference those within the Sample App to build that. This causes problems if underlying types change.

Describe the solution

We should make the projects within this repo aware of if they're within a sub-module somehow (probably a build property that's only flagged on the Main Repo). This would switch the PackageReferences used here to be ProjectReferences.

In this way, we could include the sub-module in the main repo and build all the components as part of that CI in addition to the Sample App being unified.

Any changes to the main repo could then be fixed here and then move the sub-module marker and re-tested in the sample app a lot more easily without having to do NuGet shenanigans.

Describe alternatives you've considered

Otherwise, we'd have to probably move this whole repo within the context of the main repo, but then that makes it harder to just pick up and contribute to the graph related controls.

FYI @azchohfi @shweaver-MSFT thoughts?

@ghost ghost added the needs triage 🔍 label Jan 14, 2021
@ghost
Copy link

ghost commented Jan 14, 2021

Hello michael-hawker, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant