Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic improvements #46

Open
kangarang opened this issue May 16, 2018 · 0 comments
Open

Semantic improvements #46

kangarang opened this issue May 16, 2018 · 0 comments

Comments

@kangarang
Copy link
Contributor

kangarang commented May 16, 2018

i think it's worth changing some names to increase readability

majority bloc - group of voters who voted the majority rule

(plcr)
function isPassed -> majorityBlocVotedFor

  • returns true if the applicant won a challenge

(tcr)
uint rewardPool -> majorityBlocRewardPct

  • integer percentage value; used to calculate the amount of reward tokens transferred to msg.sender once claimReward is called

(plcr)
function getTotalNumberOfTokensForWinningOption -> getTotalMajorityBlocNumTokens

  • returns either the votesFor or votesAgainst (whichever is greater)

(tcr)
uint totalTokens -> totalMajorityBlocNumTokens

  • value returned from voting.getTotalNumberOfTokensForWinningOption -- either the votesFor or votesAgainst (whichever is greater)

winning voter - single voter who voted in the majority rule

(plcr)
function getNumPassingTokens -> getWinningVoterNumTokens

  • returns the number of tokens a majority bloc voter voted in a poll
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant