Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify "no more recipients" check #1426

Open
macfarla opened this issue Apr 4, 2022 · 0 comments
Open

Verify "no more recipients" check #1426

macfarla opened this issue Apr 4, 2022 · 0 comments

Comments

@macfarla
Copy link
Contributor

macfarla commented Apr 4, 2022

Verify that this line does what's expected

// this means there are no recipients in the payload (which we receive when we are a
// participant)
if (!buffer.hasRemaining()) {

https://github.com/ConsenSys/tessera/blob/095ab4fee41d13bb914b10b366ab8ecc6c6018da/enclave/enclave-api/src/main/java/com/quorum/tessera/enclave/PayloadEncoderImpl.java#L138

https://github.com/ConsenSys/tessera/blob/095ab4fee41d13bb914b10b366ab8ecc6c6018da/enclave/enclave-api/src/test/java/com/quorum/tessera/enclave/encoder/V2PayloadEncoder.java#L109
macfarla added a commit to macfarla/tessera that referenced this issue Apr 4, 2022
@macfarla
removed todos and created issue see Consensys#1426
357fdfb 
Signed-off-by: Sally MacFarlane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@macfarla