Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lambda list #76

Open
Jeanne-jw opened this issue Aug 7, 2023 · 2 comments
Open

Lambda list #76

Jeanne-jw opened this issue Aug 7, 2023 · 2 comments

Comments

@Jeanne-jw
Copy link

For the calculation of metrics, there is a small error in lambda list.
In the filewf-psf/wf_psf/metrics/metrics_interface.py, in the function evaluate_metrics_mono_rmse(), lambda_list is set as np.arange(0.55, 0.9, 0.01). However, sometimes the up limit will not be included in np.arange. In this case, the last term is 0.89, and $\lambda=0.9\mu m$ is not included in the list.

@tobias-liaudat
Copy link
Member

Hi @Jeanne-jw
Why do you say that sometimes the up limit is not included?

The problem is that the behaviour changes with numpy version or that the 0.9um value should be always included in the list?

@Jeanne-jw
Copy link
Author

You are right. In np.arange(), the interval is half-open as [start, stop), so it's always not included. https://numpy.org/doc/stable/reference/generated/numpy.arange.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants