Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor train_utils module #89

Open
jeipollack opened this issue Dec 7, 2023 · 0 comments
Open

Refactor train_utils module #89

jeipollack opened this issue Dec 7, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@jeipollack
Copy link
Contributor

A review of the train_utils module revealed areas needing improving in terms of code quality. There are duplicated commands, hard-coded values and many nested-if statements.

Refactoring should apply the following:

  • Moving duplicated commands and if-statements either to individual functions, or a dictionary of options with specific function calls, or strategy design pattern to handle the different settings
  • Convert hard-coded values to options or remove entirely
@jeipollack jeipollack added the enhancement New feature or request label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To Do but not priority
Development

No branches or pull requests

1 participant