Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motif matching when using mouse data #18

Open
AmandaKedaigle opened this issue Mar 15, 2023 · 6 comments
Open

Motif matching when using mouse data #18

AmandaKedaigle opened this issue Mar 15, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@AmandaKedaigle
Copy link

AmandaKedaigle commented Mar 15, 2023

Hi! I was running into an issue when selecting TFs in my mouse data, because the motif names did not match many genes in the gene exp data. I ended up altering the SelectTFs and GetTFGeneCorrelation code to

rownames(trajMM) <- stringr::str_to_title(object@assays[[atac.assay]]@[email protected])

(although maybe a biomaRt matching or something would be more accurate) and am getting better results, so I thought I'd note it!

@lzj1769
Copy link
Member

lzj1769 commented Mar 22, 2023

Hi @AmandaKedaigle

Thanks for reporting this point. Indeed, we only tested the function using human data, where the gene names are all capitalized.

Using biomatRt is absolutely better and I will add it to our TODO.

Thanks,
Zhijian

@lzj1769 lzj1769 self-assigned this Mar 22, 2023
@lzj1769 lzj1769 added the enhancement New feature or request label Mar 22, 2023
@Dalhte
Copy link

Dalhte commented Jul 26, 2023

Hi! I was running into an issue when selecting TFs in my mouse data, because the motif names did not match many genes in the gene exp data. I ended up altering the SelectTFs and GetTFGeneCorrelation code to

rownames(trajMM) <- stringr::str_to_title(object@assays[[atac.assay]]@[email protected])

(although maybe a biomaRt matching or something would be more accurate) and am getting better results, so I thought I'd note it!

Dear @AmandaKedaigle

I'm trying to make scMega works and I encounter the same problem as you did: the matrix names are not recognized. I would like to do the same modification you did (modifying the rownames(trajMM) code but I'm truly lost about how to do it, I can't find the file containing the selectTFs function in my ScMega R libs. Can you help me ?

Best regards

David

@AmandaKedaigle
Copy link
Author

AmandaKedaigle commented Jul 26, 2023

Hi David! If you're using RStudio you can write View(function_name) to see code for a function in a loaded package (or View(package_name::function_name). I believe that outside of RStudio you can still see the code with just the function name, no parentheses. I just copied the code for those functions into a new script, altered that line, and then loaded my new functions overtop of the package ones. Hope this helps!

@Dalhte
Copy link

Dalhte commented Jul 26, 2023

Hi Amanda
Thanks a lot ! It's working :)
Just to know, did you had incompatibility problems between ScMEGA and seurat V5 (if you use seurat that is ?) I have this error poping up : Error in GetAssayData():
! No layers are found
Best and thanks again :)
David

@AmandaKedaigle
Copy link
Author

I was using Seurat, but was still on v4 - didn't run into that one!

@Dalhte
Copy link

Dalhte commented Jul 26, 2023

the V5 is a bit annoying with lots of incompatibility !
Thanks a lot for your help !
Best
David

This was referenced Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants