Crash When Creating A World With VillagersPlus

[RyanSalad]

I have confirmed no other issue reports this bug

• I have searched for existing issues

I have confirmed the mod is installed on the proper side

• I have installed the mod properly

Current behavior

Every time I attempt to create a new world, it results in a crash. It also won't let me load previously created worlds

Expected behavior

It should let me create new worlds or at least allow me to load into my other worlds

Steps to reproduce

1. Create an instance with Soul Fire'd 4.0.2, Cobweb 1.0.0, Forge Config API Port 4.2.11, Cloth Config 8.3.115, and VillagersPlus 1.9.2 installed.
2. Click the Create New World button
3. Game crashes

Minecraft version

1.19.2

Mod loader version

Fabric 0.16.2

Mod version

4.0.2

Other mods

Cobweb 1.0.0
Forge Config API Port 4.2.11
Cloth Config 8.3.115
VillagersPlus 1.9.2

Stacktrace and logs

crash-2024-08-18_14.02.52-client.txt
latest.log

Additional context

I noticed this issue when I updated Soul Fire'd and Harvest With Ease to the versions that require Cobweb 1.0.0, so I whittled my modpack all the way down to these mods. Everything works fine with older versions of Soul Fire'd and Cobweb. I haven't created an issue in the VillagersPlus GitHub yet because I figured this issue only arose when I updated Soul Fire'd, but let me know if I should bring it to their attention too

[Crystal-Spider]

We'll check it out as soon as we return from vacation (~1 week).

In the meantime, can you confirm that using older Soul Fire'd and Harvest with ease versions does not result in a crash when paired with VillagerPlus?

Thank you for the patience.

[RyanSalad]

In the meantime, can you confirm that using older Soul Fire'd and Harvest with ease versions does not result in a crash when paired with VillagerPlus?

I can confirm this as I was choosing not to update from Soul Fire'd 3.2.1.0, Harvest with Ease 9.0.0.3-beta, and Cobweb 0.5.5-beta for a while because I still wanted to play with all of these mods without the issues, and it has been working fine on those lower versions when paired with VillagersPlus

Also, thank you for getting back to me in such short notice. I look forward to hearing more when you and your team return from vacation

[Crystal-Spider]

I could replicate the issue, working on it

[Crystal-Spider]

Okay, I managed to find the cause:

VillagerPlus 1.9.2 has some code to handle trades from datapacks.
Soul Fire'd 4.y.z introduces the uses of dynamic datapacks leveraging Cobweb API.
When VillagerPlus tries to retrieve data from a datapack, the only way it checks if the current datapack it's handling uses VillagerPlus namespace is by checking for errors (or null) when trying to open it. However, Cobweb dynamic datapacks are made to be safe-fails, so they don't give any errors and instead return an empty stream. This leads to null JSON data that causes the crash.

The fix is quite easy, but it's on VillagerPlus side: they can either add a null check here or add a call to ResourcePack#contains(PackType, ResourceLocation) here.

So, I suggest you open an issue on their side, and feel free to report my findings to them and link to this issue.

[RyanSalad]

Okay thank you for investigating. I'll open up an issue on their side and try to link this issue with your findings & suggestions