Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable issue #39

Open
4 of 6 tasks
Dunkstormen opened this issue Feb 17, 2018 · 6 comments
Open
4 of 6 tasks

DataTable issue #39

Dunkstormen opened this issue Feb 17, 2018 · 6 comments

Comments

@Dunkstormen
Copy link

  • I'm submitting a ...
    • bug report
    • feature request
    • support request

Please only submit the section relevant to what you are submitting.

Bug Report

  • What is the current behavior?
    When making a search on the "Players" page it would spit out an error using console.log stating that an error occured in DataTables (http://datatables.net/tn/7). When looking in the Network tab in the Developer Tools, I can see it reporting the error code 400 with the message "Failed CSRF check!"

  • What is the expected behavior?
    The expected behavior would be that it would finish it's query and display data matching the query.

  • Steps to reproduce?

    1. Sign into the panel
    2. Go to the "Players" page
    3. Type a search query in the search field.
  • Please tell us about your environment:
    Linux VPS running Ubuntu (16.04) [fully updated]
    PHP 7.0
    Apache 2
    MySQL (MariaDB 10.1.30)

  • Checklist

    • Attached Relevant Logs
    • Steps to reproduce
    • Screenshots
  • Other information
    Error that gets displayed when searching:
    https://i.imgur.com/CucVItj.png
    https://i.imgur.com/SJwFW9s.png

@cammygames cammygames self-assigned this Feb 18, 2018
@cammygames
Copy link
Member

Was able to reproduce this slightly when internet connection is limited, will investigate further to implement solution.

@Dunkstormen
Copy link
Author

Just a bit curious, is there any progress regarding this issue?

@MightySCollins
Copy link
Member

Not yet AFAIK its to do with CSRF checking and not noticeable with a good internet collection and fast DB server

@Dunkstormen
Copy link
Author

Dunkstormen commented Mar 10, 2018

Been doing some thinking/research and have come to the conclusion that the problem may be in the connection between my VPS that is running the panel and our dedicated server.

Though the connections should be fast enoungh, I guess that the way packet has to travel has an impact on CSRF check.

Connection details:
Dedicated server: 600Mbps/600Mbps (Located in DK) (Proxied with remote DDoS protection located in RO)
Web server / VPS : 100Mbps/100Mbps (Located in NL)
My own connection: 50Mbps/10Mbps (Located in DK)

I'll try get a VPS that can reach our DS over LAN and see if that resolves the issue. Will let you know when I've tried it out.

@Dunkstormen
Copy link
Author

Dunkstormen commented Mar 10, 2018

UPDATE

System seems to be running faster now after I reinstalled my VPS, updated PHP to 7.1.15 and used the direct IP instead of proxied IP. Though issue still occurs when typing a search query fast in the search box. So I/we would need to wait for it to process in between each character when searching

Example:
I want to find a player named "Steward Johnson". I go to the players page and start searching for him. Starting by pressing "S" and waiting about ½ a second for it to process, then continuing by pressing "T" and so on.

@MightySCollins
Copy link
Member

If thats half fixed it I think your next problem is going to be your database. Is players a big table and is MySQL running well? Its still an issue but until we change how we do our entire CSRF system speeding up those requests should help/

@cammygames cammygames removed their assignment Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants