Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broaden addDependency to encompass actions #2197

Open
lifflander opened this issue Oct 4, 2023 · 0 comments · May be fixed by #2359
Open

Broaden addDependency to encompass actions #2197

lifflander opened this issue Oct 4, 2023 · 0 comments · May be fixed by #2359
Assignees

Comments

@lifflander
Copy link
Collaborator

Currently we can't do this because dependencies are automatically released based on an epoch terminating, but this is an action completing which would release it potentially too early. We should broaden how dependencies work so they can be manually created/released for cases like this.


          Should we add a dependency between epoch and encapsulated_epoch? The runtime could detect circular dependencies that way and I think(?) it lowers the number of termination detection messages.

If we changed the order of handling an epoch finishing so that when epoch x finishes we inform dependent epochs only after enqueuing x's actions, we could also remove the explicit produce/consumes and just use epoch dependencies and runnables.

Originally posted by @Matthew-Whitlock in #2196 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants