Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a proper all-reduce algorithm for GroupManager #2281

Open
JacobDomagala opened this issue May 7, 2024 · 0 comments · May be fixed by #2337
Open

Use a proper all-reduce algorithm for GroupManager #2281

JacobDomagala opened this issue May 7, 2024 · 0 comments · May be fixed by #2337
Assignees
@JacobDomagala @cwschilly
Labels
type: task
Milestone
Add new allreduce

Comments

@JacobDomagala
Copy link
Contributor

No description provided.

@JacobDomagala JacobDomagala added this to the Add new allreduce milestone May 7, 2024
@JacobDomagala JacobDomagala self-assigned this May 7, 2024
JacobDomagala added a commit that referenced this issue Jul 24, 2024
@JacobDomagala
#2281: Initial work to make collective group info contain the informa…
be5b4a1 
…tion about all the nodes from that group
JacobDomagala added a commit that referenced this issue Aug 13, 2024
@JacobDomagala
#2281: Initial work to make collective group info contain the informa…
7099798 
…tion about all the nodes from that group
JacobDomagala added a commit that referenced this issue Aug 13, 2024
@JacobDomagala
#2281: Working nodes information for each group node
f796cdd
JacobDomagala added a commit that referenced this issue Aug 13, 2024
@JacobDomagala
#2281: Working original Rabenseifner with groups
6abe118
JacobDomagala added a commit that referenced this issue Aug 13, 2024
@JacobDomagala
#2281: Working allreduce with Groups. Only thing missing is executing…
93ebc31 
… final handler
JacobDomagala added a commit that referenced this issue Aug 13, 2024
@JacobDomagala
#2281: Working Handler execution on ObjGroup
325cde6
@JacobDomagala JacobDomagala linked a pull request Aug 13, 2024 that will close this issue
Draft
@JacobDomagala JacobDomagala linked a pull request Aug 13, 2024 that will close this issue
#2281: Add new allreduce algorithms for Group, Objgroup and Collection #2337
Draft
JacobDomagala added a commit that referenced this issue Aug 21, 2024
@JacobDomagala
#2281: Fix issue with collective groups' default_group and root_node …
d48e90d 
…information
JacobDomagala added a commit that referenced this issue Aug 21, 2024
@JacobDomagala
#2281: Initial work for using new allreduce within collections
7c7f870
JacobDomagala added a commit that referenced this issue Aug 25, 2024
@JacobDomagala
#2281: Working Rabenseifner (without final handler) for collection
434a2b7
JacobDomagala added a commit that referenced this issue Aug 25, 2024
@JacobDomagala
#2281: Add template param for Rabenseifner to determine how to procee…
05d8cb6 
…d with handler
JacobDomagala added a commit that referenced this issue Aug 26, 2024
@JacobDomagala
#2281: Working handler execution
868c89c
JacobDomagala added a commit that referenced this issue Aug 29, 2024
@JacobDomagala
#2281: Initial work to make collective group info contain the informa…
907d0ef 
…tion about all the nodes from that group
JacobDomagala added a commit that referenced this issue Aug 29, 2024
@JacobDomagala
#2281: Working nodes information for each group node
9c5ee3c
JacobDomagala added a commit that referenced this issue Aug 29, 2024
@JacobDomagala
#2281: Working original Rabenseifner with groups
4fffa8b
JacobDomagala added a commit that referenced this issue Aug 29, 2024
@JacobDomagala
#2281: Working allreduce with Groups. Only thing missing is executing…
9a98e50 
… final handler
JacobDomagala added a commit that referenced this issue Aug 29, 2024
@JacobDomagala
#2281: Working Handler execution on ObjGroup
49c4903
JacobDomagala added a commit that referenced this issue Aug 29, 2024
@JacobDomagala
#2281: Fix issue with collective groups' default_group and root_node …
3a3f31a 
…information
JacobDomagala added a commit that referenced this issue Aug 29, 2024
@JacobDomagala
#2281: Initial work for using new allreduce within collections
a3a4b1a
JacobDomagala added a commit that referenced this issue Aug 29, 2024
@JacobDomagala
#2281: Working Rabenseifner (without final handler) for collection
83a80c9
JacobDomagala added a commit that referenced this issue Aug 29, 2024
@JacobDomagala
#2281: Add template param for Rabenseifner to determine how to procee…
4e266c7 
…d with handler
JacobDomagala added a commit that referenced this issue Aug 29, 2024
@JacobDomagala
#2281: Working handler execution
3a20f6b
JacobDomagala added a commit that referenced this issue Aug 29, 2024
@JacobDomagala
#2281: Make final handler in Rabenseifner a callback
3a003f9
JacobDomagala added a commit that referenced this issue Aug 29, 2024
@JacobDomagala
#2281: Fix the issue with DataHan::reduce
6047b5d
JacobDomagala added a commit that referenced this issue Aug 29, 2024
@JacobDomagala
#2281: Make GroupManager and ObjManager also use callback for final h…
81b4d00 
…andler (Rabenseifner)
JacobDomagala added a commit that referenced this issue Sep 2, 2024
@JacobDomagala
#2281: Working perf test with collection
27d1929
JacobDomagala added a commit that referenced this issue Oct 11, 2024
@JacobDomagala
#2281: Working perf test with collection
503d64b
JacobDomagala added a commit that referenced this issue Oct 11, 2024
@JacobDomagala
#2281: Setup perf test for groups and remove the parent proxy, as we …
5bbbb59 
…now store the final handler with callback
JacobDomagala added a commit that referenced this issue Oct 11, 2024
@JacobDomagala
#2281: Remove RabenseifnerGroup as we've now integrated groups and co…
23c0a6f 
…llections into the original struct
JacobDomagala added a commit that referenced this issue Oct 11, 2024
@JacobDomagala
#2281: Add unit tests for new callback (BcastCollective)
9f2cbaf
JacobDomagala added a commit that referenced this issue Oct 11, 2024
@JacobDomagala
#2281: Refactor Rabensifer a bit so it doesn't require that many temp…
57aa52b 
…late arguments, also let the User specify which algorithm to use
JacobDomagala added a commit that referenced this issue Oct 11, 2024
@JacobDomagala
#2281: Implement state holder and use it for Rabenseifner
028a354
JacobDomagala added a commit that referenced this issue Oct 11, 2024
@JacobDomagala
#2281: Implement clear function for StateHolder that frees dynamic me…
1aa6f98 
…mory allocated for allreduce state
JacobDomagala added a commit that referenced this issue Oct 11, 2024
@JacobDomagala
#2281: Working Rabenseifner with updated StateHolder
fde360f
JacobDomagala added a commit that referenced this issue Oct 11, 2024
@JacobDomagala
#2281: Typeless Rabensifner and small fixes to StateHolder
679344d
JacobDomagala added a commit that referenced this issue Oct 11, 2024
@JacobDomagala
#2281: Typeless RecursiveDoubling and general code refactor/cleanup
2e7b6e6
JacobDomagala added a commit that referenced this issue Oct 11, 2024
@JacobDomagala
#2281: RecursiveDoubling allreduce - add Collection support
0c7f5dd
JacobDomagala added a commit that referenced this issue Oct 11, 2024
@JacobDomagala
#2281: Add unit tests for new Collection allreduce
c86244b
JacobDomagala added a commit that referenced this issue Oct 11, 2024
@JacobDomagala
#2281: Small fixes and code cleanup
76c377c
JacobDomagala added a commit that referenced this issue Oct 11, 2024
@JacobDomagala
#2281: Update documentation for new allreduce algorithms
1bafd3b
JacobDomagala added a commit that referenced this issue Oct 11, 2024
@JacobDomagala
#2281: Initial work for AllreduceHolder
30b1882
JacobDomagala added a commit that referenced this issue Oct 11, 2024
@JacobDomagala
#2281: Fix runtime Kokkos when we run with both device/host memory sp…
0eb340b 
…aces
JacobDomagala added a commit that referenced this issue Oct 11, 2024
@JacobDomagala
#2281: Working AllreduceHolder with all (Collection/Group/ObjGroup) c…
3fb1ddd 
…omponents
JacobDomagala added a commit that referenced this issue Oct 11, 2024
@JacobDomagala
#2281: Fixed runtime issues with StateHolder generating extra ID
ae65729
JacobDomagala added a commit that referenced this issue Oct 11, 2024
@JacobDomagala
#2281: Update license and add reduce_op.h file for Kokkos reduce oper…
d118fa9 
…ators
JacobDomagala added a commit that referenced this issue Oct 11, 2024
@JacobDomagala
#2281: Always create allreducers for new collective group
c61db0c
JacobDomagala added a commit that referenced this issue Oct 11, 2024
@JacobDomagala
#2281: New allreducers no longer require Objgroup for internal commun…
7caed11 
…ication. This helps for cases when not all Nodes are part of allreduce
JacobDomagala added a commit that referenced this issue Oct 11, 2024
@JacobDomagala
#2281: Code refactor and minor bug fixes
e24cacc
JacobDomagala added a commit that referenced this issue Oct 11, 2024
@JacobDomagala
#2281: Sort out the PendingSends in new allreduce methods
46c73af
JacobDomagala added a commit that referenced this issue Oct 11, 2024
@JacobDomagala
#2281: Don't use explicit Kokkos::HostSpace for Kokkos::View in Raben…
33c5e98 
…seifnerMsg and ShouldUseView
JacobDomagala added a commit that referenced this issue Oct 11, 2024
@JacobDomagala
#2281: Cleanup StateHolder (move implementation to .cc impl.h files)
ed1f880
JacobDomagala added a commit that referenced this issue Oct 11, 2024
@JacobDomagala
#2281: Resolve issue with incorrect index generated by StateHolder::g…
332ad94 
…etNextID
JacobDomagala added a commit that referenced this issue Oct 11, 2024
@JacobDomagala
#2281: Resolve issue with incorrect index generated by StateHolder::g…
164328c 
…etNextID
JacobDomagala added a commit that referenced this issue Oct 14, 2024
@JacobDomagala
#2281: Resolve issue with incorrect index generated by StateHolder::g…
5c33e20 
…etNextID
cwschilly added a commit that referenced this issue Nov 5, 2024
@cwschilly
#2281: use or remove unused variables
eee5e69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JacobDomagala JacobDomagala

@cwschilly cwschilly

Labels
type: task
Projects
None yet
Milestone
Add new allreduce
Development

Successfully merging a pull request may close this issue.

#2281: Add new allreduce algorithms for Group, Objgroup and Collection DARMA-tasking/vt
2 participants
@JacobDomagala @cwschilly