Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace is_same<..., Footprinter> with is_footprinter<...> #2354

Closed
Matthew-Whitlock opened this issue Sep 24, 2024 · 1 comment · Fixed by #2361
Closed

Replace is_same<..., Footprinter> with is_footprinter<...> #2354

Matthew-Whitlock opened this issue Sep 24, 2024 · 1 comment · Fixed by #2361

Comments

@Matthew-Whitlock
Copy link
Contributor

Once Magistrate merges in DARMA-tasking/magistrate#345, the type passed to serializers will be a wrapper around the old serializer types. This requires changing one line in VT:

std::is_same<SerializerT, checkpoint::Footprinter>::value

Which can become:
checkpoint::is_footprinter_v<SerializerT>

@PhilMiller
Copy link
Member

The standard suggestion for not breaking CI and other work flows is to introduce that tiny type trait in a preliminary PR that can be merged easily and make the necessary change in vt before anything will break without it. It looks like it would be pretty trivial to separate the non-specialized bits in https://github.com/DARMA-tasking/magistrate/pull/345/files#diff-55e1997dc89d4418466fb76518870de26637ba41f902ddb390280457c69724b9 in magistrate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants