From e820b2fca16e716cd57908e97583eb176779beed Mon Sep 17 00:00:00 2001 From: Felix Clack Date: Thu, 13 Jul 2023 08:13:00 +0100 Subject: [PATCH] Remove default values for OIDC configuration In a [discussion on a different PR](https://github.com/DFE-Digital/access-your-teaching-qualifications/pull/234#discussion_r1260947743), there was a suggestion to remove the default values from the OIDC configuration to trigger misconfiguration messages sooner, eg. on app startup. The idea is that this would make development better as any misconfiguration error would be clearer. --- config/initializers/omniauth.rb | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/config/initializers/omniauth.rb b/config/initializers/omniauth.rb index 2340acc3..f210be5f 100644 --- a/config/initializers/omniauth.rb +++ b/config/initializers/omniauth.rb @@ -5,9 +5,9 @@ OmniAuth.config.on_failure = proc { |env| AuthFailuresController.action(:failure).call(env) } # DSI setup -dfe_sign_in_identifier = ENV.fetch("DFE_SIGN_IN_CLIENT_ID", "example") -dfe_sign_in_secret = ENV.fetch("DFE_SIGN_IN_SECRET", "example") -dfe_sign_in_redirect_uri = ENV.fetch("DFE_SIGN_IN_REDIRECT_URL", "example") +dfe_sign_in_identifier = ENV["DFE_SIGN_IN_CLIENT_ID"] +dfe_sign_in_secret = ENV["DFE_SIGN_IN_SECRET"] +dfe_sign_in_redirect_uri = ENV["DFE_SIGN_IN_REDIRECT_URL"] dfe_sign_in_issuer_uri = ENV["DFE_SIGN_IN_ISSUER"].present? ? URI(ENV["DFE_SIGN_IN_ISSUER"]) : nil options = { name: :dfe, @@ -41,7 +41,7 @@ # Identity setup Rails.application.config.middleware.use OmniAuth::Builder do provider :identity, - ENV.fetch("IDENTITY_CLIENT_ID"), - ENV.fetch("IDENTITY_CLIENT_SECRET"), + ENV["IDENTITY_CLIENT_ID"], + ENV["IDENTITY_CLIENT_SECRET"], { path_prefix: "/qualifications/users/auth" } end