From 1c41d73e889410d577990adf569424e884b895fe Mon Sep 17 00:00:00 2001 From: michael-conway Date: Fri, 7 Apr 2017 07:38:01 -0400 Subject: [PATCH] #2 refactoring for rest --- .../irods/jargon/metadatatemplate/JargonMetadataResolver.java | 4 +--- .../jargon/metadatatemplate/JargonMetadataResolverTest.java | 1 + 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/metadata-templates/src/main/java/org/irods/jargon/metadatatemplate/JargonMetadataResolver.java b/metadata-templates/src/main/java/org/irods/jargon/metadatatemplate/JargonMetadataResolver.java index 7992746..f804130 100644 --- a/metadata-templates/src/main/java/org/irods/jargon/metadatatemplate/JargonMetadataResolver.java +++ b/metadata-templates/src/main/java/org/irods/jargon/metadatatemplate/JargonMetadataResolver.java @@ -282,8 +282,6 @@ public MetadataTemplate findTemplateByNameInPublicTemplates(final String name) t MetadataTemplate returnTemplate = null; IRODSFile collectionIrodsFile = null; - boolean matched = false; - // for (String publicDir : getPublicTemplateLocations()) { try { collectionIrodsFile = this.getIrodsAccessObjectFactory() @@ -301,7 +299,6 @@ public MetadataTemplate findTemplateByNameInPublicTemplates(final String name) t try { returnTemplate = processFileToMetadataTemplate((IRODSFile) f); - matched = true; } catch (JargonException je) { log.error("JargonException in processFileToMetadataTemplate", je); log.info("Matched {} with {}, but file could not be processed", name, f.getAbsolutePath()); @@ -451,6 +448,7 @@ private String generateMdTemplateFileName() { StringBuilder sb = new StringBuilder(); sb.append("mdtemplate"); sb.append(System.currentTimeMillis()); + sb.append(MetadataTemplateConstants.TEMPLATE_FILE_EXT); return sb.toString(); } diff --git a/metadata-templates/src/test/java/org/irods/jargon/metadatatemplate/JargonMetadataResolverTest.java b/metadata-templates/src/test/java/org/irods/jargon/metadatatemplate/JargonMetadataResolverTest.java index 39a7b8a..f2f635a 100644 --- a/metadata-templates/src/test/java/org/irods/jargon/metadatatemplate/JargonMetadataResolverTest.java +++ b/metadata-templates/src/test/java/org/irods/jargon/metadatatemplate/JargonMetadataResolverTest.java @@ -158,6 +158,7 @@ public void testListPublic() throws Exception { JargonMetadataResolver resolver = new JargonMetadataResolver(context, accessObjectFactory, metadataConfiguration); + UUID uuid = resolver.saveTemplate(template, MetadataTemplateLocationTypeEnum.PUBLIC); List metadataTemplates = resolver.listPublicTemplates();