Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OracleDynamicParameters.Add( size ) documentation #45

Open
kbilsted opened this issue Sep 4, 2020 · 1 comment
Open

OracleDynamicParameters.Add( size ) documentation #45

kbilsted opened this issue Sep 4, 2020 · 1 comment

Comments

@kbilsted
Copy link

kbilsted commented Sep 4, 2020

Hi

Many thanks for this library!

Can you please document the optional parameter size on OracleDynamicParameters.Add()? The code was not obvious to me. Perhaps it is evident if you have more Oracle knowledge than I have.

Also what happens when you guess a size of 4000 but the result actually is larger?

While it may sound like a random parameter to document, I think these aspects are crucial to understand in order to be able to use this library.

many thanks

@epaulsen
Copy link
Contributor

Sorry for the delayed response, missed this.
First off, thank you for the kind words.

This library is a thin shim which enables Dapper to use native Oracle methods directly exposed through .net Oracle driver without Dapper knowing the internals of the Oracle driver. So for the Add method of OracleDynamicParameter we should ideally refer users over to the Oracle documentation for parameters.
BTW: That can be found here: https://docs.oracle.com/cd/E11882_01/win.112/e23174/OracleParameterClass.htm#ODPNT1729

I do agree that documentation could definitely be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants