Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider self-distributing the Firefox add-on #691

Open
Rongronggg9 opened this issue Apr 16, 2022 · 3 comments
Open

Consider self-distributing the Firefox add-on #691

Rongronggg9 opened this issue Apr 16, 2022 · 3 comments

Comments

@Rongronggg9
Copy link
Contributor

Rongronggg9 commented Apr 16, 2022

Context: #635 (comment)

TL;DR

You really should read the context.

Add-ons distributed on AMO (https://addons.mozilla.org) are unable to use eval(), making remote rules updating and local rules modifications impossible. However, a self-distributed add-on faces much looser reviews so that's possible to enable both features. Here is a toturial on how to self-distributing Firefox add-ons.

You really should not read this

In fact, no reviews, but automatic checks and approval.

Shhh...

An effective example

rsshub_radar-1.7.1-fx.zip (already signed by AMO so it can be installed easily, change the ext name to xpi if needed)
Modifications on local rules are no longer ignored, making it possible to update rules by yourself, or debug your own rules before summiting a new RSSHub route, cheers!
As for remote rules, it is still disabled. But you must be a magical girl who loved a cyber chef, right?

P4xF1rYWBS+cSclbXFWDY4+ady5FUSK8PuHFYOM=bv7+p8J1poRKB9vcpW+cUWK1PzwySFwadNSlUx+1PugmpzPKavL+s+KAPr+mxrSJ5o5eovMApSPKYOvcB+n7XyxW
Disclaimer
  • My self-distributed add-on comes with absolutely no warranty.
  • So do remote rules. Technically speaking, enabling remote rules is allowing remote code execution (RCE), so you are the only one responsible for your action.
  • The add-on contains some code from a drafting PR. I was just too lazy to remove it.
  • The add-on contains some useless changes. I was just too lazy to remove them.
  • You can audit the source code yourself: https://github.com/Rongronggg9/RSSHub-Radar/tree/ff

Related issues / PRs

Shouldn't #667 be enough? Probably not. Radar rules are now required for any new RSSHub routes. No reason to force a Firefox user to install Chromium or modify the code of RSSHub-Radar (then build and install on Firefox) before they can debug their radar rules, isn't it? What's more, a sideloaded add-on will be uninstalled automatically at quit (only Nightly, Beta, or ESR may escape if configured - but only <20% Firefox users use these three channels), so that's also an unacceptable solution for ordinary Firefox users.

Here's a contributor who had to waste a lot of time before realizing RSSHub-Radar is almost completely broken on Firefox (DIYgod/RSSHub#9537).

Other related issues: #687 #660 #408 #460 #675

@simpread
Copy link

谜语人啊,第二段解密不出来QAQ

@Seele0oO
Copy link

https://github.com/Seele0oO/RSSHub-Radar
I did it.
Just click on the release xpi file to complete the installation.
I only make sure it works for regular users like me.
As well as it won't have live updates to upstream, I haven't finished writing the github action configuration yet. If anyone would like to submit a Pull Request appreciate it.

@DIYgod
Copy link
Owner

DIYgod commented Nov 19, 2023

I am reconsidering self-distribution. A Firefox extension reviewer informed me that he couldn't reproduce the same results from our source code on his Ubuntu, leading him to remove the publication of our extensions. This is very ridiculous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants