You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have contributed to a few issues and got this idea. If I add new features to a route by adding new parameters into the route path in router.js, without updating maintainer.js at the same time, then the route path in these two files won't match.
For example, one route is /user/dynamic/:uid/:disableEmbed?, and I add a showEmoji parameter. After this, the path in router.js is /user/dynamic/:uid/:showEmoji?/:disableEmbed?, but in maintainer.js it is still /user/dynamic/:uid/:disableEmbed?.
So I wonder if combining these two is a good idea since they share the same path strings. If possible, I only need to modify the path once while adding new params.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I have contributed to a few issues and got this idea. If I add new features to a route by adding new parameters into the route path in
router.js
, without updatingmaintainer.js
at the same time, then the route path in these two files won't match.For example, one route is
/user/dynamic/:uid/:disableEmbed?
, and I add ashowEmoji
parameter. After this, the path inrouter.js
is/user/dynamic/:uid/:showEmoji?/:disableEmbed?
, but inmaintainer.js
it is still/user/dynamic/:uid/:disableEmbed?
.So I wonder if combining these two is a good idea since they share the same path strings. If possible, I only need to modify the path once while adding new params.
Beta Was this translation helpful? Give feedback.
All reactions