Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle dpdk port "siblings" #40

Open
david-marchand opened this issue Jul 10, 2024 · 1 comment
Open

handle dpdk port "siblings" #40

david-marchand opened this issue Jul 10, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@david-marchand
Copy link
Member

When releasing a DPDK port and asking for detaching/freeing its associated HW resources, care must be taken not to break port "siblings" that were sharing those HW resources.

See testpmd or OVS:
https://git.dpdk.org/dpdk/tree/app/test-pmd/testpmd.c#n3674
https://github.com/openvswitch/ovs/blob/main/lib/netdev-dpdk.c#L1747
christophefontaine referenced this issue in christophefontaine/grout Jul 19, 2024
@christophefontaine
infra/port: handle siblings on removal
40d97f5 
On device removal, check if the port has siblings
before calling rte_dev_remove.

Fixes: https://github.com/rjarry/grout/issues/40
Signed-off-by: Christophe Fontaine <[email protected]>
@christophefontaine
Copy link
Contributor

Which hardware relies on siblings ?
I'd like to test rjarry/grout@main...christophefontaine:grout:issue_40

christophefontaine referenced this issue in christophefontaine/grout Jul 24, 2024
@christophefontaine
infra/port: handle siblings on removal
5b2e1e3 
On device removal, check if the port has siblings
before calling rte_dev_remove.

Fixes: https://github.com/rjarry/grout/issues/40
Signed-off-by: Christophe Fontaine <[email protected]>
@christophefontaine christophefontaine added the bug Something isn't working label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@christophefontaine @david-marchand