From 38fa032e17ca219f2e64c389fc267bdb287e9aba Mon Sep 17 00:00:00 2001
From: Kapu1178 <75460809+Kapu1178@users.noreply.github.com>
Date: Sat, 24 Feb 2024 02:25:21 -0500
Subject: [PATCH] Fix ninja screenshot tests (#828)

* fix the suit

* run forrest run

* im coping

* upload new image
---
 .github/workflows/ci_suite.yml                  |   2 +-
 code/modules/ninja/suit/suit.dm                 |   1 +
 .../screenshot_antag_icons_spaceninja.png       | Bin 640 -> 635 bytes
 3 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/ci_suite.yml b/.github/workflows/ci_suite.yml
index bad7daa287c1..456995385523 100644
--- a/.github/workflows/ci_suite.yml
+++ b/.github/workflows/ci_suite.yml
@@ -150,7 +150,7 @@ jobs:
       - run: echo Alternate tests passed.
 
   compare_screenshots:
-    if: ( !contains(github.event.head_commit.message, '[ci skip]') && (success() || failure()) )
+    if: ( !contains(github.event.head_commit.message, '[ci skip]') && (always() && (!failure() && !cancelled())) )
     needs: [run_all_tests, run_alternate_tests]
     name: Compare Screenshot Tests
     runs-on: ubuntu-latest
diff --git a/code/modules/ninja/suit/suit.dm b/code/modules/ninja/suit/suit.dm
index d11ec002ff5d..221dd744f7d9 100644
--- a/code/modules/ninja/suit/suit.dm
+++ b/code/modules/ninja/suit/suit.dm
@@ -15,6 +15,7 @@
 	inhand_icon_state = "s-ninja_suit"
 	allowed = list(/obj/item/gun, /obj/item/ammo_box, /obj/item/ammo_casing, /obj/item/melee/baton, /obj/item/restraints/handcuffs, /obj/item/tank/internals, /obj/item/stock_parts/cell)
 	resistance_flags = LAVA_PROOF | ACID_PROOF
+	flags_inv = HIDESHOES|HIDEJUMPSUIT
 	armor = list(BLUNT = 40, PUNCTURE = 30, SLASH = 0, LASER = 20, ENERGY = 30, BOMB = 30, BIO = 30, FIRE = 100, ACID = 100)
 	strip_delay = 12
 	min_cold_protection_temperature = SPACE_SUIT_MIN_TEMP_PROTECT
diff --git a/code/modules/unit_tests/screenshots/screenshot_antag_icons_spaceninja.png b/code/modules/unit_tests/screenshots/screenshot_antag_icons_spaceninja.png
index 4ffa78dfe2c748c4cae58f1f90569be01301678e..4c5d2cbf1981e35b494c53f9457de29134ad83a9 100644
GIT binary patch
delta 416
zcmV;R0bl-r1^Wb$Bmqc~B_)wfCj^s5^t6$9fPZmGL_t(&f$f*kQiCuQL`zgKR7Ftq
z|Nqq8$#zJ^(bQ5#?4Fl2^k&ZtncSwkoiWB3W6YXVGb~tD5JI?_frr6@OmGYCCNQ&L
zH34(#x@KzAH1_~QgBc#yOE@ej62ur=fK&?T!VC|i1qaZaW0FwNrt~FSwgn|{ue0CF
z1%Dge_60G$?l_}LPc68tU=MTv<^mlD)>v>M0Tw<0<+KUztUgM@n%_ybEnw$S4j0c-
z4=#MCS$kS{vfxJ^6MJnmcmh)c;;1iJqw?z!pmch#fgy;aK&ja;CuZ4pl}aoq6?9$4
zS*3Jvd=9kNtU+mK!IA>(8cWq&o<ZOD9DlM+o~|xh5z>mHezbkTFbppM!z*C&IF1~?
z+ymAOX$c1lmK10O!pGEyD&6ChOt7=VarspV6#fQq4))mvBHcB3Bp^6zlP&nx!9$?%
zUYBg8$|V8IB`FNI;1oUyl$w1!=O5<(5cE0#>e25LYS({3@Bv?KcT+tIp!fg)00{s|
KMNUMnLSTaag}595

delta 422
zcmV;X0a^b01b_vQBmqm2B_#u}u&|LzCj>Z>xuKDDfPZsIL_t(&f$f*!PJ}QJgpaCV
z5fwqv_kU7n(lPYJD0mzZZ|2Wl%XYqm%`Uye!LlsNvMg&$6%!e-DIkP!H4!$00U6*L
zx*3I)0h<BnQ<f!NtE#$%5Gt&&S+2n_U=|?8SVM3nfGn)A84b9D7%`k<f)G$A_ccbg
z0ZSmPb$|A~TyfCt9}v^)juRDW*MRc^8b}Q=1*jdEW5AgJICu}qr%qyJ^-~b${0_2j
z04I-pczELa!NN1G>Sfc(fFJdc)Tq$VBQy>mMm=DT(k};q)bYIrn!t_#xn^HZtg>>=
zg%~gw(6%jCh1{XzK2WWhgVff5H36s^Q#D+kpntCG7_uUdR~MZK>BOvgw0}U~_s<Z*
z3q<E(7#O~+0dx9vgu#F{0XhNmA<dye_c%FIsBC|neo+9Kze4DPCc8kSy9QeVfRl=B
zz_$!Gfy_HyvgIn408AHTrnv!2^a&u>?B^-}F#iXjQv+y5zm3wk{tJM2&)<DnudUS}
Q01E&B07*qoM6N<$g3Beo8~^|S