-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
authenticated turn servers #13
Comments
Yeah, that needs to be addressed. I'd still like to use a terse format for defining servers that are an option but I'm not sure what that looks like yet. If you've got any ideas... |
@DamonOehlman Could use a regular expression to grab the username and password from the string, ie username:[email protected]:someport |
Or just pipe separate them, e.g:
The |
Isn't this already being fixed with |
@piranna I think you are right, as long as the URLs were formatted appropriately it should definitely work. From looking at the tests in |
That would be great :-) |
@piranna So after checking it is true that In truth, normalice is going a bit beyond it's original mission by even doing any of that as the only reason I think I wrote it was to help ease the transition between the I think the best thing I can do, is to make some reasonably simple modifications to |
What about using |
I suspect that will fail also (not sure though). Did you have turn server urls that you were going to provide? If so, without giving the actual urls away is there a format you were hoping to use? |
As an aside here's another gist with a big list of servers: https://gist.github.com/sagivo/3a4b2f2c7ac6e1b5267c2f1f59ac6c6b |
URL.parse() can identify both usernames, passwords and schemas, so it should work. Anyway, schemas are only turn:, stun: and turns: (this one currently not supported), so it's easy to identify them...
This is HUGE! :-D Would love to have them inside freeice. Maybe a tool that checks their availability nightly would be needed thought, to don't have them out of sync. |
https://gist.github.com/yetithefoot/7592580
the way this library works currently doesn't allow for objects to be put in the turn server file, only strings which means usernames and passwords cant be used
The text was updated successfully, but these errors were encountered: