Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reserved identifier violation #10

Open
elfring opened this issue Feb 26, 2017 · 3 comments
Open

reserved identifier violation #10

elfring opened this issue Feb 26, 2017 · 3 comments

Comments

@elfring
Copy link

elfring commented Feb 26, 2017

I would like to point out that identifiers like “_EFLAGS” and “_CPU_VENDORdo not fit to the expected naming convention of the C language standard.
Would you like to adjust your selection for unique names?

@DarthTon
Copy link
Owner

DarthTon commented Mar 6, 2017

It's unlikely that I'll change the code to be fully compatible with C standard. I doubt it can cause any real conflicts and compiler will give warning if anything goes wrong.

@elfring
Copy link
Author

elfring commented Mar 6, 2017

How do you think about to avoid that this software depends on undefined behaviour?

@DarthTon
Copy link
Owner

DarthTon commented Mar 6, 2017

It doesn't depend on it. It may have undefined behavior because of reserved identifier conflict, but it's the smallest issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants