Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log request body #6404

Open
achave11-ucsc opened this issue Jul 12, 2024 · 1 comment
Open

Log request body #6404

achave11-ucsc opened this issue Jul 12, 2024 · 1 comment
Assignees
Labels
- [priority] Medium code [subject] Production code compliance [subject] Information and software security enh [type] New feature or request orange [process] Done by the Azul team

Comments

@achave11-ucsc
Copy link
Member

achave11-ucsc commented Jul 12, 2024

https://github.com/DataBiosphere/azul-private/issues/128#issuecomment-2224116914

@hannes-ucsc: "Don't file partial PR against #128 but instead a normal PR against this issue."

[edit, @achave11-ucsc, updated specification]

@achave11-ucsc achave11-ucsc added orange [process] Done by the Azul team enh [type] New feature or request code [subject] Production code compliance [subject] Information and software security - [priority] Medium labels Jul 12, 2024
achave11-ucsc added a commit that referenced this issue Aug 31, 2024
achave11-ucsc added a commit that referenced this issue Sep 26, 2024
achave11-ucsc added a commit that referenced this issue Sep 27, 2024
achave11-ucsc added a commit that referenced this issue Oct 1, 2024
achave11-ucsc added a commit that referenced this issue Oct 1, 2024
achave11-ucsc added a commit that referenced this issue Oct 1, 2024
achave11-ucsc added a commit that referenced this issue Oct 17, 2024
achave11-ucsc added a commit that referenced this issue Oct 17, 2024
achave11-ucsc added a commit that referenced this issue Oct 17, 2024
achave11-ucsc added a commit that referenced this issue Oct 17, 2024
achave11-ucsc added a commit that referenced this issue Oct 17, 2024
Add test for new request body logging
achave11-ucsc added a commit that referenced this issue Oct 17, 2024
achave11-ucsc added a commit that referenced this issue Oct 17, 2024
Add test for new request body logging
achave11-ucsc added a commit that referenced this issue Oct 17, 2024
achave11-ucsc added a commit that referenced this issue Oct 17, 2024
Add test for new request body logging
achave11-ucsc added a commit that referenced this issue Oct 17, 2024
achave11-ucsc added a commit that referenced this issue Oct 18, 2024
Add test for new request body logging
achave11-ucsc added a commit that referenced this issue Oct 21, 2024
achave11-ucsc added a commit that referenced this issue Oct 21, 2024
achave11-ucsc added a commit that referenced this issue Oct 21, 2024
Add test for new request body logging
achave11-ucsc added a commit that referenced this issue Oct 21, 2024
achave11-ucsc added a commit that referenced this issue Oct 22, 2024
Add test for new request body logging
achave11-ucsc added a commit that referenced this issue Oct 22, 2024
achave11-ucsc added a commit that referenced this issue Oct 22, 2024
Add test for new request body logging
achave11-ucsc added a commit that referenced this issue Oct 22, 2024
achave11-ucsc added a commit that referenced this issue Oct 22, 2024
Add test for new request body logging
achave11-ucsc added a commit that referenced this issue Oct 22, 2024
achave11-ucsc added a commit that referenced this issue Oct 24, 2024
Add test for new request body logging
achave11-ucsc added a commit that referenced this issue Oct 29, 2024
Add test for new request body logging
achave11-ucsc added a commit that referenced this issue Oct 30, 2024
Add test for new request body logging
@achave11-ucsc
Copy link
Member Author

@hannes-ucsc: "I originally specified this as follows:"

Assignee to implement a partial PR that adds logging of the request body by Chalice middleware, similar to how we log the response body. With AZUL_DEBUG set to 0 or 1, the length and the first 1024 bytes of the request body should be logged. With AZUL_DEBUG set to 2, the length of the body, and the full body should be logged.

Once the logging of the request body length has been deployed for a couple of months, we can resume the original plan.

@hannes-ucsc: "Doing PR review, I noticed that this is inconsistent with the logging of response bodies. Here is the updated specification: At AZUL_DEBUG=0, only log the length of the request and response bodies. At AZUL_DEBUG=1 log the length and the first 1024 bytes of these bodies. At AZUL_DEBUG=2 log the length and the complete body."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- [priority] Medium code [subject] Production code compliance [subject] Information and software security enh [type] New feature or request orange [process] Done by the Azul team
Projects
None yet
Development

No branches or pull requests

2 participants