Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various problems in can_bundle script #6669

Open
nadove-ucsc opened this issue Oct 31, 2024 · 1 comment
Open

Various problems in can_bundle script #6669

nadove-ucsc opened this issue Oct 31, 2024 · 1 comment
Assignees
@nadove-ucsc
Labels
+ [priority] High bug [type] A defect preventing use of the system as specified code [subject] Production code debt [type] A defect incurring continued engineering cost demo [process] To be demonstrated at the end of the sprint doc [subject] Internal and external documentation orange [process] Done by the Azul team

Comments

@nadove-ucsc
Copy link
Contributor

nadove-ucsc commented Oct 31, 2024 •
edited
Loading

  • Inaccurate module-level docstring
  • Faulty/brittle default value for source parameter
  • Incorrect help message for version parameter
  • Inference for AnVIL-specific bundle FQID fields will stop working once replica bundles are introduced
@nadove-ucsc nadove-ucsc added the orange [process] Done by the Azul team label Oct 31, 2024
nadove-ucsc added a commit that referenced this issue Oct 31, 2024
@nadove-ucsc
Fix: Inaccurate module-level docstring in can_bundle script (#6669)
ea3e362
nadove-ucsc added a commit that referenced this issue Oct 31, 2024
@nadove-ucsc
Fix: Faulty/brittle default value for source parameter in can_bundle …
3735676 
…script (#6669)
nadove-ucsc added a commit that referenced this issue Oct 31, 2024
@nadove-ucsc
Fix: Incorrect help message for version parameter in can_bundle script (
bfc2010 
#6669)
nadove-ucsc added a commit that referenced this issue Oct 31, 2024
@nadove-ucsc
can_bundle script requires explicit table name for AnVIL sources (#6669)
ccc5e22
@nadove-ucsc nadove-ucsc mentioned this issue Oct 31, 2024
Merged
@nadove-ucsc nadove-ucsc added bug [type] A defect preventing use of the system as specified doc [subject] Internal and external documentation debt [type] A defect incurring continued engineering cost code [subject] Production code labels Oct 31, 2024
@nadove-ucsc nadove-ucsc self-assigned this Oct 31, 2024
@nadove-ucsc nadove-ucsc added the + [priority] High label Oct 31, 2024
nadove-ucsc added a commit that referenced this issue Oct 31, 2024
@nadove-ucsc
fixup! can_bundle script requires explicit table name for AnVIL sourc…
c6799f3 
…es (#6669)
@hannes-ucsc hannes-ucsc added the demo [process] To be demonstrated at the end of the sprint label Nov 2, 2024
@hannes-ucsc
Copy link
Member

For demo, can one bundle from a source indexed by prod and a bundle of every type from a source indexed by anvilprod.

hannes-ucsc pushed a commit that referenced this issue Nov 2, 2024
@nadove-ucsc @hannes-ucsc
can_bundle script requires explicit table name for AnVIL sources (#6669)
d5d6b41
achave11-ucsc pushed a commit that referenced this issue Nov 5, 2024
@nadove-ucsc @achave11-ucsc
Fix: Inaccurate module-level docstring in can_bundle script (#6669)
8fb484b
achave11-ucsc pushed a commit that referenced this issue Nov 5, 2024
@nadove-ucsc @achave11-ucsc
Fix: Faulty/brittle default value for source parameter in can_bundle …
0380632 
…script (#6669)
achave11-ucsc pushed a commit that referenced this issue Nov 5, 2024
@nadove-ucsc @achave11-ucsc
Fix: Incorrect help message for version parameter in can_bundle script (
f46dba7 
#6669)
achave11-ucsc pushed a commit that referenced this issue Nov 5, 2024
@nadove-ucsc @achave11-ucsc
can_bundle script requires explicit table name for AnVIL sources (#6669)
2819315
nadove-ucsc added a commit that referenced this issue Nov 5, 2024
@nadove-ucsc
Fix: Inaccurate module-level docstring in can_bundle script (#6669)
644377f
nadove-ucsc added a commit that referenced this issue Nov 5, 2024
@nadove-ucsc
Fix: Faulty/brittle default value for source parameter in can_bundle …
8da52fb 
…script (#6669)
nadove-ucsc added a commit that referenced this issue Nov 5, 2024
@nadove-ucsc
Fix: Incorrect help message for version parameter in can_bundle script (
2b0d7d8 
#6669)
nadove-ucsc added a commit that referenced this issue Nov 5, 2024
@nadove-ucsc
can_bundle script requires explicit table name for AnVIL sources (#6669)
f0be49d
achave11-ucsc added a commit that referenced this issue Nov 6, 2024
@achave11-ucsc
Fix: Various problems in can_bundle script (#6669, PR #6670)
bee4a60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadove-ucsc nadove-ucsc

Labels
+ [priority] High bug [type] A defect preventing use of the system as specified code [subject] Production code debt [type] A defect incurring continued engineering cost demo [process] To be demonstrated at the end of the sprint doc [subject] Internal and external documentation orange [process] Done by the Azul team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hannes-ucsc @nadove-ucsc