Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify and enforce bundle FQID equality semantics #6671

Open
nadove-ucsc opened this issue Oct 31, 2024 · 1 comment
Open

Clarify and enforce bundle FQID equality semantics #6671

nadove-ucsc opened this issue Oct 31, 2024 · 1 comment
Assignees
@nadove-ucsc
Labels
+ [priority] High code [subject] Production code debt [type] A defect incurring continued engineering cost doc [subject] Internal and external documentation no demo [process] Not to be demonstrated at the end of the sprint orange [process] Done by the Azul team test [subject] Unit and integration test code

Comments

@nadove-ucsc
Copy link
Contributor

The indexer assumes that uuid and version are the only attributes that determine equality semantics between instances of BundleFQID. This assumption is inconsistently enforced, and the catalog_complete IT subtest could be made much simpler if we could rely on it.
@nadove-ucsc nadove-ucsc added code [subject] Production code orange [process] Done by the Azul team + [priority] High doc [subject] Internal and external documentation debt [type] A defect incurring continued engineering cost test [subject] Unit and integration test code labels Oct 31, 2024
nadove-ucsc added a commit that referenced this issue Oct 31, 2024
@nadove-ucsc
Clarify and enforce bundle FQID equality semantics (#6671)
ca8cd51
@nadove-ucsc
Copy link
Contributor Author

This change is also necessary to make the catalog_complete subtest compatible with upcoming changes from #6626

@nadove-ucsc nadove-ucsc self-assigned this Oct 31, 2024
@nadove-ucsc nadove-ucsc mentioned this issue Oct 31, 2024
Merged
nadove-ucsc added a commit that referenced this issue Nov 1, 2024
@nadove-ucsc
fixup! Clarify and enforce bundle FQID equality semantics (#6671)
05387cb
nadove-ucsc added a commit that referenced this issue Nov 1, 2024
@nadove-ucsc
fixup! Clarify and enforce bundle FQID equality semantics (#6671)
e2d707a
@hannes-ucsc hannes-ucsc added the no demo [process] Not to be demonstrated at the end of the sprint label Nov 1, 2024
nadove-ucsc added a commit that referenced this issue Nov 3, 2024
@nadove-ucsc
Clarify and enforce bundle FQID equality semantics (#6671)
91d9cf7
nadove-ucsc added a commit that referenced this issue Nov 3, 2024
@nadove-ucsc
fixup! Clarify and enforce bundle FQID equality semantics (#6671)
48b5fa4
achave11-ucsc pushed a commit that referenced this issue Nov 5, 2024
@nadove-ucsc @achave11-ucsc
Clarify and enforce bundle FQID equality semantics (#6671)
4e99857
achave11-ucsc added a commit that referenced this issue Nov 5, 2024
@achave11-ucsc
Clarify and enforce bundle FQID equality semantics (#6671, PR #6672)
787c416
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadove-ucsc nadove-ucsc

Labels
+ [priority] High code [subject] Production code debt [type] A defect incurring continued engineering cost doc [subject] Internal and external documentation no demo [process] Not to be demonstrated at the end of the sprint orange [process] Done by the Azul team test [subject] Unit and integration test code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hannes-ucsc @nadove-ucsc