Stop accepting value counter passed as --type when using Dogshell cli

[gdubicki]

Describe the bug

My team has been using dogshell to post metrics with --type counter since at least 2020. I know that this is not documented but it's a pretty obvious different way to write --type count and it works.

The problem is that "counter" seems to actually be a different metric type than "count" in Datadog and while they behave mostly the same, the former seems to be deprecated and it doesn't support some features, like "Metrics without limits".

To Reproduce

Submit a metric --type counter with dogshell.

Expected behavior

• An error that the type is unsupported should be returned. The command exit code should be non-zero.

or

• Under the hood the type count should be used and an exit code 0 should be returned. Maybe a warning should be printed that the type counter is not supported and that count has been used?

Environment and Versions (please complete the following information):

$ dog --version
dog 0.49.1

Additional context

The information about the "counter" type not supporting "Metrics without limits" comes from this (private) Datadog support request: https://help.datadoghq.com/hc/en-us/requests/1691412

[github-actions]

Thanks for your contribution!

This issue has been automatically marked as stale because it has not had activity in the last 30 days. Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity. Thank you for participating in the Datadog open source community.

If you would like this issue to remain open:

1. Verify that you can still reproduce the issue in the latest version of this project.

2. Comment that the issue is still reproducible and include updated details requested in the issue template.