Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of non-playable cards #163

Open
Snadjim opened this issue Sep 6, 2024 · 2 comments
Open

Addition of non-playable cards #163

Snadjim opened this issue Sep 6, 2024 · 2 comments

Comments

@Snadjim
Copy link

Snadjim commented Sep 6, 2024

Hello ,

I noticed that these 3 cards are missing from the aggreate json file

https://yugipedia.com/wiki/Obelisk_the_Tormentor_(original) : LC01-EN001
https://yugipedia.com/wiki/Slifer_the_Sky_Dragon_(original) : LC01-EN002
https://yugipedia.com/wiki/The_Winged_Dragon_of_Ra_(original) : LC01-EN003

Is it possible to add them as well as the other non-playable cards?

Regards,

Nadjim

@kevinlul
Copy link
Contributor

kevinlul commented Sep 9, 2024

These cards are currently intentionally excluded as they cannot be used in a Duel and were never in Bastion.

# Normal monster version OCG prize cards, Tyler, OG Egyptian Gods
wikitext.get("database_id") == "none"
or
# Match winners, Command Duel-Use Card (only one with dbid None), etc. have db ids but no passwords
"limitation_text" in wikitext
or
# Boss Duel cards
wikitext.get("ocg_status") == "Illegal"

A few options for proceeding:

  • Transform these cards, but output them to a different directory than data/cards
  • Include them in data/cards, but continue to exclude them from Bastion with a filter
  • Include them in data/cards and start showing them in Bastion

@kevinlul
Copy link
Contributor

kevinlul commented Oct 3, 2024

To do: need to include limitation_text from the wiki in the output and then surface in Bastion.

kevinlul added a commit that referenced this issue Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants