Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PWMMotorMediator physically realistic #88

Closed
brettle opened this issue Jul 4, 2024 · 1 comment
Closed

Make PWMMotorMediator physically realistic #88

brettle opened this issue Jul 4, 2024 · 1 comment
Assignees
@brettle

Comments

@brettle
Copy link
Member

brettle commented Jul 4, 2024

  • Make the expected values in PWMMotorTest correct based on the physics at work.
  • Fix PWMMotorMediator so that it passes the test
@brettle brettle mentioned this issue Jul 4, 2024
Closed
@brettle brettle self-assigned this Jul 7, 2024
@brettle brettle mentioned this issue Jul 7, 2024
Closed
brettle added a commit that referenced this issue Jul 9, 2024
@brettle
Fix Make PWMMotorMediator physically realistic #88.
079310e 
Also fix #100 (use DBSBrake to ensure unique name).
brettle added a commit that referenced this issue Jul 10, 2024
@brettle
Merge pull request #102 from DeepBlueRobotics/make-PWMMotorController…
c7a6d0b 
…Test-realistic

Fix Make `PWMMotorMediator` physically realistic #88.
@brettle
Copy link
Member Author

brettle commented Jul 13, 2024

Fixed by #102.

@brettle brettle closed this as completed Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brettle brettle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brettle