Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the fp16 mode of mmdeploy grid_sampler #94

Open
kamiLight opened this issue Jan 3, 2024 · 1 comment
Open

Question about the fp16 mode of mmdeploy grid_sampler #94

kamiLight opened this issue Jan 3, 2024 · 1 comment

Comments

@kamiLight
Copy link

It seems to mmdeploy grid_sampler do not support fp16 (i.e nvinfer1::DataType::kHALF) according to https://github.com/open-mmlab/mmdeploy/blob/bc75c9d6c8940aa03d0e1e5b5962bd930478ba77/csrc/mmdeploy/backend_ops/tensorrt/grid_sampler/trt_grid_sampler.cpp#L110, so i wonder that mmdeploy grid_sampler will do nothing just return 1 if using fp16 mode? In this case, wouldn't we get the wrong result? Thanks!

@admyxs
Copy link

admyxs commented Mar 7, 2024

It seems to mmdeploy grid_sampler do not support fp16 (i.e nvinfer1::DataType::kHALF) according to https://github.com/open-mmlab/mmdeploy/blob/bc75c9d6c8940aa03d0e1e5b5962bd930478ba77/csrc/mmdeploy/backend_ops/tensorrt/grid_sampler/trt_grid_sampler.cpp#L110, so i wonder that mmdeploy grid_sampler will do nothing just return 1 if using fp16 mode? In this case, wouldn't we get the wrong result? Thanks!

about this question

Do you know the answer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants