Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Q.UNWATCH for websocket #1154

Open
psrvere opened this issue Oct 19, 2024 · 2 comments · May be fixed by #1180
Open

Add Q.UNWATCH for websocket #1154

psrvere opened this issue Oct 19, 2024 · 2 comments · May be fixed by #1180
Assignees
@psrvere
Labels
difficulty-level -- mid new -- command stack -- go

Comments

@psrvere
Copy link
Contributor

psrvere commented Oct 19, 2024 •
edited
Loading

Follow up work on PR #1090

Also

  • address this comment - unsubscribe when the Q.WATCH connection is terminated.
  • fix integration & unit tests - unsubscribe after every subscription
@psrvere
Copy link
Contributor Author

psrvere commented Oct 19, 2024

@lucifercr07 - please assign this to me.

@psrvere psrvere mentioned this issue Oct 19, 2024
Merged
This was referenced Oct 21, 2024
Open
Draft
@psrvere
Copy link
Contributor Author

psrvere commented Oct 23, 2024

I have created a draft PR #1180

This PR will open for review once PR #1175 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psrvere psrvere

Labels
difficulty-level -- mid new -- command stack -- go
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Q.UNWATCH to Websockets psrvere/dice
2 participants
@psrvere @JyotinderSingh