Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

variant/emendation against mRest crashes #11

Open
zolaemil opened this issue Feb 20, 2014 · 3 comments
Open

variant/emendation against mRest crashes #11

zolaemil opened this issue Feb 20, 2014 · 3 comments
Labels
bug

Comments

@zolaemil
Copy link
Contributor

No description provided.

@zolaemil zolaemil added the bug label Feb 20, 2014
@ahankinson
Copy link
Member

Is this what is causing the segfault?

@zolaemil
Copy link
Contributor Author

No, that only causes the transformation to fail.

@zolaemil
Copy link
Contributor Author

zolaemil commented Mar 5, 2014

The problem: when determining which notes/rests to wrap inside an (or ) mRests aren't searched for (neither in the variant nor in the variant staves)

Solution:

  1. when extracting colored blocks, a colored mRest generates a colored block of the length of a measure (expressed in semi-breves)
  2. consider mRests found in the lemma staff when aligning colored blocks with the lemma.

zolaemil added a commit to zolaemil/MEIMassaging that referenced this issue Mar 9, 2014
@zolaemil
fixed: 'index out of range' if lemma <staff> is empty
8bb3a3b 
- extended whole-measure test case to test this behaviour.
- commented out the last measure of this test case, because it’s
currently makes the test fail due to
DuChemin#11
zolaemil added a commit to zolaemil/MEIMassaging that referenced this issue Mar 9, 2014
@zolaemil
mRest is considered on lemma staves
01c5055 
fixes: DuChemin#11
zolaemil added a commit to zolaemil/MEIMassaging that referenced this issue Mar 9, 2014
@zolaemil
test for DuChemin#11
a7e3f9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahankinson @zolaemil