Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop segmenting moves after Z bed compensation taper completes #888

Closed
T3P3 opened this issue Aug 2, 2023 · 3 comments
Closed

Stop segmenting moves after Z bed compensation taper completes #888

T3P3 opened this issue Aug 2, 2023 · 3 comments
Assignees
Labels
Done - Needs Testing enhancement Additional functionality, performance or other feature request
Milestone

Comments

@T3P3
Copy link
Contributor

T3P3 commented Aug 2, 2023

to improve input shaping performance.

@T3P3 T3P3 added the enhancement Additional functionality, performance or other feature request label Aug 2, 2023
@T3P3 T3P3 added this to the 3.5.0 milestone Aug 2, 2023
@T3P3 T3P3 assigned dc42 Aug 2, 2023
@chrishamm chrishamm assigned chrishamm and unassigned dc42 Aug 2, 2023
@chrishamm
Copy link
Collaborator

Changed in 0dec97f

@AndyEveritt
Copy link
Collaborator

Some initial testing suggests that there is no improvement to input shaping because of this change. Will try some more test objects.

The expected issue is that IS is not being applied on the deceleration of a move that too long (relative to the bed mesh spacing)

Tested by printing 2 cubes on the bed with a large spacing between them (multiple times the bed mesh spacing), and enabling a taper for the mesh compensation.

Ringing was noticed on the edge immediately after the travel move (expected because IS won't be applied), but no change was seen before or after the taper height.

@chrishamm
Copy link
Collaborator

I just did a brief test on my setup with the latest firmware. I can confirm segmentation does NOT take place if the nozzle is above the defined fade height. To test this, I generated a mesh, enabled move debugging via M111 P4 S1, and drove the nozzle across the bed twice at varying heights. In the serial log I could see only two DMs if above the configured taper height (for X and Y respectively) and below the fade height I got several more DMs, which indicates that segmentation is taking place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Done - Needs Testing enhancement Additional functionality, performance or other feature request
Projects
None yet
Development

No branches or pull requests

4 participants