Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job file position reported by RRF is occasionally not valid #901

Closed
T3P3 opened this issue Aug 30, 2023 · 5 comments
Closed

Job file position reported by RRF is occasionally not valid #901

T3P3 opened this issue Aug 30, 2023 · 5 comments
Assignees
Labels
bug Bug that has been reproduced Done - Needs Testing
Milestone

Comments

@T3P3
Copy link
Contributor

T3P3 commented Aug 30, 2023

Possibly related to: #794

Potentially only happens when two input channels are running at the same time, for example daemon.g

@T3P3 T3P3 assigned T3P3 and dc42 and unassigned T3P3 Aug 30, 2023
@T3P3 T3P3 added this to the 3.5.0 milestone Aug 30, 2023
@T3P3
Copy link
Contributor Author

T3P3 commented Aug 30, 2023

May be the cause of: #899

@T3P3 T3P3 added the bug Bug that has been reproduced label Aug 30, 2023
@chrishamm
Copy link
Collaborator

@dc42
Copy link
Collaborator

dc42 commented Aug 30, 2023

When I run a job comprising a single G28 command followed by many G2 S1 commands, with daemon.g echoing job.filePosition every 800ms, usually see 1 or 2 instances of file position 4294967291 near the start, I presume while homedelta.g is running. I don't see any bad file positions after that.

If I put a M291 command requiring a user response in the file, then while the response is awaited the file position reported is zero.

I tried having the job use M98 to call a macro that delays 10 seconds, but the file position was reported correctly while that was executing.

So it appears to me that this issue is associated with running homing macros (and perhaps other system macros, but not user macros) and with using M291.

If I pause the job, the file position is reported correctly while the job is paused.

If I add a G4 delay command and an echo message to the end of the homing file, the file position is reported correctly until the echo message has been output, then I get a single bad position after that. So it appears that the bad position is associated with a system macro file ending.

@chrishamm
Copy link
Collaborator

chrishamm commented Aug 31, 2023

Fixed by 5ea064e. Needs to be merged into v3.5 and backported to v3.4, [dc42 - now merged and back ported.]

@dc42
Copy link
Collaborator

dc42 commented Aug 31, 2023

I created a new issue #902 for the case of M291 being executed.

@dc42 dc42 closed this as completed Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug that has been reproduced Done - Needs Testing
Projects
None yet
Development

No branches or pull requests

3 participants