Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: M954 by itself doesn't output the set CAN address #926

Closed
2 of 25 tasks
jaysuk opened this issue Nov 3, 2023 · 2 comments
Closed
2 of 25 tasks

[Bug]: M954 by itself doesn't output the set CAN address #926

jaysuk opened this issue Nov 3, 2023 · 2 comments
Assignees
Labels
notplanned currently not planned also a low priority/unlikely to be implemented in the future
Milestone

Comments

@jaysuk
Copy link

jaysuk commented Nov 3, 2023

Duet Forum Discussion Thread

N/A

Which Duet products are you using?

  • Duet2-Wifi
  • Duet2-Ethernet
  • Duet Expansion Breakout Board
  • Duex2
  • Duex5
  • Duet2-Maestro
  • Maestro Dual Driver Expansion
  • Duet3-6HC
  • Duet3-3HC
  • Duet3-1XD
  • Duet3-1LC
  • Duet3-Tool Distribution Board
  • Duet3-Mini5+
  • Duet3-Mini2+
  • Raspberry Pi or other SBC
  • SmartEffector
  • Magnetic Filament Sensor
  • Laser Filament Sensor
  • PT100 Daughterboard
  • Thermocouple Daughterboard
  • PanelDue
  • Other
  • None

Firmware Version

3.4.6

Duet Web Control Version

3.4.6

Are you using a Single Board Computer (RaspberryPi) with your Duet?

  • Yes I use a SBC.
  • No I do not use a SBC.

Please upload the results of sending M122 in the gcode console.

N/A

Please upload the content of your config.g file.

N/A

Please upload the content of any other releveant macro files.

N/A

Details specific to your printer.

N/A

Links to additional info.

N/A

What happened?

It's expected that when a Gcode that doesn't have any arguements outputs it's assigned value
M954 doesn't and it expects Ax to also be included

@jaysuk jaysuk added the bug Bug that has been reproduced label Nov 3, 2023
@dc42
Copy link
Collaborator

dc42 commented Feb 19, 2024

What would be the purpose of this? The CAN address of the main board is always zero, and to use M954 on an expansion board you need to specify its CAN address using the B parameter. Either way, you already know the CAN address. The only situation in which I think it has a possible use is if you configure a main board as an expansion board, and then send commands directly to that board over USB or UART; but that's an odd use case.

@T3P3 T3P3 added this to the 3.5.2 milestone May 20, 2024
@T3P3 T3P3 added notplanned currently not planned also a low priority/unlikely to be implemented in the future and removed bug Bug that has been reproduced labels May 20, 2024
@T3P3
Copy link
Contributor

T3P3 commented May 20, 2024

not planned until we understand a usecase.

@T3P3 T3P3 closed this as completed May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notplanned currently not planned also a low priority/unlikely to be implemented in the future
Projects
None yet
Development

No branches or pull requests

4 participants