Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cohort API: Implement predefined filter functionality for complex datatypes #39

Open
snathanvj opened this issue Jun 30, 2023 · 2 comments
Assignees
Labels
feature new feature

Comments

@snathanvj
Copy link
Contributor

snathanvj commented Jun 30, 2023

TO DECIDE:
Do we need to keep false values here ,

"dataTypes": {
"biospecimens": true,
"environmentalData": true,
"genomicData": false,
"phenotypicData": false
},

Can't it be simply

"dataTypes": [ "biospecimens", "environmentalData"]

@amnonkhen @theisuru

@snathanvj snathanvj added the feature new feature label Jun 30, 2023
@snathanvj snathanvj self-assigned this Jun 30, 2023
@snathanvj
Copy link
Contributor Author

pushed changes :
java:Converted DataType to enum contants
db: changed dtaaType to String array

@theisuru
Copy link
Member

theisuru commented Jul 17, 2023

This model is taken from BMMRI model. So we might need it's structure.
The "other" entry could hold text value for other data types, any idea how we can store them if we keep a ENUM?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature
Projects
None yet
Development

No branches or pull requests

2 participants