Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-intuitive naming of JSON elements in study response #72

Open
ramiromagno opened this issue Oct 9, 2018 · 1 comment
Open

Non-intuitive naming of JSON elements in study response #72

ramiromagno opened this issue Oct 9, 2018 · 1 comment
Labels
User request

Comments

@ramiromagno
Copy link

ramiromagno commented Oct 9, 2018 •
edited
Loading

Looking at the REST API documentation for the Study resource we can see that initialSampleSize and replicationSampleSize are both typed as Strings as they contain textual descriptions about samples of the association study. Yet, their name, by having Size in it suggests that it is numeric, i.e. the size of each respective sample.

So my question is: is this just an unfortunate naming choice or could there be a bug? Was there the intention to have sample sizes reported? If so, would it not be useful to have also numeric variables initialSampleSize and replicationSampleSize, respectively, and change initialSampleSize and replicationSampleSize to initialSampleDescription and replicationSampleDescription, respectively?

Thanks!
@cmalangone
Copy link
Contributor

cmalangone commented Oct 15, 2018 •
edited
Loading

Please find more details about the status of this issue here:
https://www.ebi.ac.uk/panda/jira/browse/GOCI-2440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
User request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@twhetzel @cmalangone @ramiromagno