New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

master branch to-do list #76

Open

gfasanel opened this issue Dec 5, 2016 · 0 comments

Contributor

gfasanel commented Dec 5, 2016

Hi,
I have few suggestions to have a fully functional master branch

Insert back the GetCorrTree method in EnergyScaleCorrection_class
The dat file with the corrections will be on /eos/project/.... but at the moment I think the class have some problems in finding a file on eos
Small fix in macro/plot_data_mc.C to avoid warnings/errors when compiling (img_filename is not directly used and the output is dumped in a TString)
https://github.com/ECALELFS/ECALELF/blob/workflow_test/ZFitter/macro/plot_data_mc.C#L277

Cheers,
Giuseppe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment