Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introspective metadata endpoint #125

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

CasperWA
Copy link
Contributor

@CasperWA CasperWA commented May 10, 2022

Description:

Closes #113

This PR introduces an introspective endpoint along with a new "module" of endpoints (/admin), the introspective one being at /admin/info.

To do still:

  • Use a pydantic model for the response.
    This will make it easier to process the response by machines.
  • Ensure security around all /admin endpoints.

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist for the reviewer:

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

Flesh it out, support editable installations.
Split them into "std", "editable", and "external".
"std" are the "normal" packages that show up during `pip freeze`, e.g.,
in the form of `oteapi-core==0.1.6`.
"editable" are all the ones showing up in `pip list`, but not `pip
freeze --exclude-editable`.
"external" is everything in `pip freeze` that isn't in the "std" format.
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2022

Codecov Report

Attention: Patch coverage is 29.26829% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 57.86%. Comparing base (b85048c) to head (8e9ff21).

Files Patch % Lines
app/routers/admin.py 29.26% 29 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
- Coverage   59.47%   57.86%   -1.62%     
==========================================
  Files          20       21       +1     
  Lines         728      769      +41     
==========================================
+ Hits          433      445      +12     
- Misses        295      324      +29     
Flag Coverage Δ
pytest 57.86% <29.26%> (-1.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quaat quaat self-assigned this Jan 18, 2024
CasperWA and others added 3 commits January 18, 2024 11:59
Update GH Actions:
* Bump peter-evans/create-pull-request from 5 to 6 (#388)
* Bump codecov/codecov-action from 3 to 4 (#387)

Update dependencies:
* Update fakeredis requirement from ~=2.20 to ~=2.21 in /.dev (#390)
* Update `requirements.txt` (#391)

Add codecov token.

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@CasperWA
Copy link
Contributor Author

CasperWA commented May 8, 2024

@quaat you've approved this, but do you maybe have a local version that is more up-to-date? Otherwise, I can pick this back up and finish it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An introspective metadata endpoint
5 participants