Polish celery/remote transformation strategy
#240
Conversation
Update strategy models.
|
Great success concerning the new test and running it in CI: https://github.com/EMMC-ASBL/oteapi-core/actions/runs/4316062964/jobs/7531325447#step:8:89 |
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master EMMC-ASBL/oteapi-core#240 +/- ##
==========================================
+ Coverage 81.20% 81.89% +0.69%
==========================================
Files 41 41
Lines 1128 1127 -1
==========================================
+ Hits 916 923 +7
+ Misses 212 204 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
TODO: Add special condition for Windows OS.
Add test to check CeleryConfig can be instantiated with aliased and non-aliased fields.
This is relevant when mixin aliases and non-aliases in the `_use_session()` method.
Description:
Closes EMMC-ASBL/oteapi-services#246
Starting with a test for running the strategy, the related strategy models have been refined. An issue for using the pytest fixtures were found - the Celery documentation has been fixed in celery/celery#7857, but this has yet to be published, which resulted in lots of wasted time :(
Currently, the test is not appropriately testing the strategy, but rather injecting it's own "test" Celery App instead of the strategy's Celery App.
The test should be updated or another should be added to check the actual implementation of the strategy works as intended.
Through this work it has become apparent that an important step is missing: Creating a Celery Task that can actually be referenced in the
get()method.I think it makes most sense to register/create tasks in the
initialize()step of the strategy. Another alternative is to have pre-defined tasks that can be referenced, however, this is slightly opaque for the user.Note: One must run a local redis instance to test the celery/remote strategy.
Type of change:
Checklist for the reviewer:
This checklist should be used as a help for the reviewer.