Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent alignment of 'attachment' icon in comments page and some changes in voting part. #214

Open
dikshashukla455 opened this issue Mar 31, 2022 · 3 comments · May be fixed by #216
Open

Inconsistent alignment of 'attachment' icon in comments page and some changes in voting part. #214

dikshashukla455 opened this issue Mar 31, 2022 · 3 comments · May be fixed by #216

Comments

@dikshashukla455
Copy link
Contributor

dikshashukla455 commented Mar 31, 2022 •
edited
Loading

Describe the bug

There are two bugs on the Comments page:

  1. There is an inconsistent alignment of the attachment icon in an input box of the comment.
  2. In a number of votes if there is only 1 vote then it should write 1 'vote' instead of 'votes' and for 0 and numbers other than 1 it should write 'votes'.

Actual Behavior

Screenshot (1009)_LI

You can see the bugs in the above image, which I have underlined.

To Reproduce

Steps to reproduce the behavior:

  1. Go to someone's comments page by clicking on that story that is present on the home page.

Expected behavior

Screenshot (1006)

By resolving all the bugs, The page will look like same as the above image.

Environment (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome

Additional Context

Add some hover transition in 'Leave a comment ' button
@dikshashukla455
Copy link
Contributor Author

@cyntss @mharshita @SundeepChand I would like to work on this issue and fix it.

@sarthakkundra
Copy link
Contributor

Good catch @dikshashukla455! Great to see your first official issue opened at EOS. Let me know if you need any help with this :)

@dikshashukla455 dikshashukla455 linked a pull request Mar 31, 2022 that will close this issue
Open
5 tasks
@dikshashukla455
Copy link
Contributor Author

Good catch @dikshashukla455! Great to see your first official issue opened at EOS. Let me know if you need any help with this :)

Yeah, sure! Thank you 😊.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated the comments page dikshashukla455/user-story
2 participants
@sarthakkundra @dikshashukla455