New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RoPE missing scale #1

Open

SamKG opened this issue Oct 22, 2024 · 0 comments

SamKG commented Oct 22, 2024 •

edited

Loading

Hi!
This repo is great! Found a small issue that may have been missed:

Llama 3.1 uses smoothing when computing the inverse frequencies in RoPE (https://github.com/huggingface/transformers/blob/049682a5a63042f087fb45ff128bfe281b2ff98b/src/transformers/modeling_rope_utils.py#L310) - this may result in some small differences between the baseline and the equinox models for the 3.1 variants when using long-contexts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment