Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why we need to average LayerNorm values over mp ranks when converting to HFformat checkpoint? #983

Open
forceshorty opened this issue Jun 26, 2023 · 0 comments
Open

Why we need to average LayerNorm values over mp ranks when converting to HFformat checkpoint? #983

forceshorty opened this issue Jun 26, 2023 · 0 comments

Comments

@forceshorty
Copy link

gpt-neox/tools/convert_module_to_hf.py

Line 199 in 2534e3d

# average layernorm stats over mp ranks

My understanding is that there should only be one set of layernorm parameters per layer, which should be the same across different mp ranks. Am I misunderstanding this? Please advise.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@forceshorty