Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Treasury Support (Halt) #20

Open
LcyDev opened this issue Jan 11, 2023 · 9 comments
Open

[Feature]: Treasury Support (Halt) #20

LcyDev opened this issue Jan 11, 2023 · 9 comments
Assignees
Labels
Improvements New improvements Priority Low Priorioty Low

Comments

@LcyDev
Copy link
Collaborator

LcyDev commented Jan 11, 2023

About

This is an alternative to VaultAPI but newer, good API and faster.

https://github.com/ArcanePlugins/Treasury/wiki/About-Treasury

https://github.com/ArcanePlugins/Treasury/wiki/Treasury's-Economy-API

@LcyDev LcyDev added Bug Something no working NotFixed This bug not fixed labels Jan 11, 2023
@EncryptSL EncryptSL added Improvements New improvements and removed Bug Something no working NotFixed This bug not fixed labels Jan 12, 2023
@EncryptSL
Copy link
Owner

Maybe in future , i can include this api.

@EncryptSL EncryptSL added the Priority Low Priorioty Low label Jan 12, 2023
@LcyDev
Copy link
Collaborator Author

LcyDev commented Jan 13, 2023

[23:11:45] [ForkJoinPool.commonPool-worker-1/ERROR]: [LiteEco] Exception executing command handler
kotlin.UninitializedPropertyAccessException: lateinit property econ has not been initialized
	at encryptsl.cekuj.net.LiteEco.getEcon(LiteEco.kt:36) ~[LiteEco-1.2.0-SNAPSHOT.jar:?]
	at encryptsl.cekuj.net.commands.MoneyCMD.onTopBalance(MoneyCMD.kt:95) ~[LiteEco-1.2.0-SNAPSHOT.jar:?]
	at java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732) ~[?:?]
	at java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:757) ~[?:?]
	at encryptsl.cekuj.net.cloud.annotations.MethodCommandExecutionHandler.execute(MethodCommandExecutionHandler.java:79) ~[LiteEco-1.2.0-SNAPSHOT.jar:?]
	at encryptsl.cekuj.net.cloud.execution.CommandExecutionHandler.executeFuture(CommandExecutionHandler.java:95) ~[LiteEco-1.2.0-SNAPSHOT.jar:?]
	at encryptsl.cekuj.net.cloud.execution.AsynchronousCommandExecutionCoordinator.lambda$coordinateExecution$1(AsynchronousCommandExecutionCoordinator.java:101) ~[LiteEco-1.2.0-SNAPSHOT.jar:?]
	at encryptsl.cekuj.net.cloud.execution.AsynchronousCommandExecutionCoordinator.lambda$coordinateExecution$3(AsynchronousCommandExecutionCoordinator.java:131) ~[LiteEco-1.2.0-SNAPSHOT.jar:?]
	at java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1395) ~[?:?]
	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) ~[?:?]
	at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) ~[?:?]
	at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) ~[?:?]
	at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) ~[?:?]
	at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) ~[?:?]

It seems you forgot to initialize or replace this variable. Used by onTopBalance()

@EncryptSL
Copy link
Owner

Its initialized but i missing rewrite format from Vault on own api.

https://github.com/EncryptSL/LiteEco/blob/main/src/main/kotlin/encryptsl/cekuj/net/commands/MoneyCMD.kt#L95

@EncryptSL
Copy link
Owner

EncryptSL commented Jan 13, 2023

Fixed by a42bf55

@EncryptSL
Copy link
Owner

Baltop and money top etc...
Fixed by this release and added alpha support for TreasuryApi needs more testing.

https://www.spigotmc.org/resources/liteeco-simple-economy-plugin-1-18-x-1-19.101934/update?update=485711

@MrIvanPlays
Copy link

Please do not add Treasury support until v2.0.0 gets released. v1 has many flaws with the API.

@EncryptSL
Copy link
Owner

Okay :)

@LcyDev LcyDev changed the title [Feature]: Treasury Support :) [Feature]: Treasury Support Jan 31, 2023
@LcyDev LcyDev changed the title [Feature]: Treasury Support [Feature]: Treasury Support (Halt) Jan 31, 2023
@LcyDev
Copy link
Collaborator Author

LcyDev commented Jul 20, 2023

Please do not add Treasury support until v2.0.0 gets released. v1 has many flaws with the API.

It seems v2.0.1 was released, time to re-implement with the new API.

@LcyDev
Copy link
Collaborator Author

LcyDev commented Jul 20, 2023

I will try to make a pull request with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvements New improvements Priority Low Priorioty Low
Projects
None yet
Development

No branches or pull requests

3 participants