Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Config version || Broken config #29

Open
LcyDev opened this issue Jan 24, 2023 · 9 comments
Open

[Feature]: Config version || Broken config #29

LcyDev opened this issue Jan 24, 2023 · 9 comments
Assignees
Labels
Improvements New improvements

Comments

@LcyDev
Copy link
Collaborator

LcyDev commented Jan 24, 2023

Type of function to add or improvement

Others

Your ideas

If the config is broken (Caused by an update for example)
Then, rename config.yml to old_config.yml and save a new config.yml

This could also be done to messages

What do you think?

@LcyDev LcyDev added the Improvements New improvements label Jan 24, 2023
@EncryptSL
Copy link
Owner

My idea now is add into config version: 1.0.0 and if config is changed by new release, rename old config and generate new or generate into config new values.

This "config broken" mean editing by user ? Or in released plugin ?

@LcyDev
Copy link
Collaborator Author

LcyDev commented Jan 25, 2023

This "config broken" mean editing by user ? Or in released plugin ?

Basically if the plugin can't load the config, no matter the reason it will rename it to old_config and save a new config.

It should also say warn in the console that this happened and maybe disable itself

@LcyDev LcyDev changed the title [Feature Request]: Act on broken config [Feature]: Config version || Broken config Jan 26, 2023
@EncryptSL
Copy link
Owner

Basically this commit d87a0bb implement version for config.yml, but if this is a great stuff i don't know, maybe can be implemented to stacktrace and do stuff in catch if config is malformated.

@LcyDev
Copy link
Collaborator Author

LcyDev commented Feb 3, 2023

I see, it's fine for now but I will probably make something soom

@LcyDev
Copy link
Collaborator Author

LcyDev commented Sep 3, 2024

I'm thinking of making a new implementation for the config soon.

@EncryptSL
Copy link
Owner

Okay

@LcyDev
Copy link
Collaborator Author

LcyDev commented Sep 3, 2024

Check out this library: https://github.com/Exlll/ConfigLib

@LcyDev
Copy link
Collaborator Author

LcyDev commented Sep 4, 2024

@EncryptSL
Copy link
Owner

Boosted-yaml seems fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvements New improvements
Projects
None yet
Development

No branches or pull requests

2 participants