Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call InventoryMoveItemEvent #1235

Open
Clashbestie opened this issue Nov 13, 2020 · 2 comments
Open

Call InventoryMoveItemEvent #1235

Clashbestie opened this issue Nov 13, 2020 · 2 comments
Labels
status:accepted This issue has been triaged and accepted type:feature-request Request for something new version:five Issue related to CB5

Comments

@Clashbestie
Copy link

Is your feature request related to a problem? Please describe.
If a Minecart gets put into a chest/dispenser there is no InventoryMoveItemEvent called, plugins like Chests++ rely on this to synchronize Chestlinks(virtual Inventorys)

Describe the solution you'd like
Move the item from an virtual hopper into the Inventory using the InventoryMoveItemEvent

Describe alternatives you've considered
As far as I know my first solution is hacky so instead there could be a small class with a onMove method that can be extended by other Plugins.
Additional context
Solution 1 would be the best for compatibility because the other Plugins dont need to be updated. And no solution would force the plugins to check every inventory for new Items and produce unnecessary CPU load.

I hope you understand my point and look into this soon.

@Clashbestie Clashbestie added status:pending Pending acceptance or closure. type:feature-request Request for something new labels Nov 13, 2020
@me4502 me4502 added status:accepted This issue has been triaged and accepted and removed status:pending Pending acceptance or closure. labels Nov 13, 2020
@me4502
Copy link
Member

me4502 commented Nov 13, 2020

I assume this is the Cart Collect/Deposit mechanic?

@Clashbestie
Copy link
Author

I assume this is the Cart Collect/Deposit mechanic?

Exactly.

@me4502 me4502 added the version:five Issue related to CB5 label Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:accepted This issue has been triaged and accepted type:feature-request Request for something new version:five Issue related to CB5
Projects
None yet
Development

No branches or pull requests

2 participants